[FIX] stock_landed_costs: landed Cost to be hidden on other product types #153371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suth-odoo
changed the title
suth-odoo
force-pushed
the
15.0-bug-fixes-stock-landed-costs-suth
branch
from
2fe94d3
to
4d6c5aa
Compare
pkyriakou
reviewed
Feb 14, 2024
There was a problem hiding this comment.
Thank you @suth-odoo 💯 I don't have anything to add, LGTM 🟢 🔝
auon-odoo
approved these changes
Feb 23, 2024
xavierbol
reviewed
Feb 26, 2024
There was a problem hiding this comment.
Hello @suth-odoo
Thanks for your work!
However the commit title does not fit our guidelines, the module in which you did the fix is stock_landed_costs and not sales.
Also, in the steps to reproduce, you say install sales but only with that module, the stock_landed_costs will not be installed as well. We should also install stock module and so with sale and stock modules, stock_landed_costs will normally automatically installed.
Can you update that and rebase your branch at the same time? 🙂
Thanks in advance!
…ypes Steps to Reproduce : - install sales, stock modules - go to products and create new - select product type as Event Ticket,Event Booth or Gift Card - Landed cost boolean is suppose to be visible for a service type product under purchase. Issue : - Landed cost boolean is suppose to be visible for a service type product under purchase, But currently it is visible on other type of products specific to other models like event tickets, event booths etc. Cause: - In product Module there are two Selection fields like detailed_type and type. The detailed_type Selection field contain service, consumable, event booths, event tickets, storable product And the type selection field contains service, consumable, storable product - In xml views for that landed cost boolean the invisible attribute contains the condition like type != service, because of this the landed cost boolean is visible for the product type of event tickets, event booths and gift Cards. Solution: - if we use detailed_type instead of type selection field, then the landed cost boolean field will be invisible on other product types. task- 3725202
suth-odoo
force-pushed
the
15.0-bug-fixes-stock-landed-costs-suth
branch
from
4d6c5aa
to
eb2ccde
Compare
suth-odoo
changed the title
suth-odoo
changed the title
|
Hello @xavierbol |
xavierbol
approved these changes
Feb 27, 2024
|
Hello @odoo/rd-logistics Can we have your opinion about that fix before merging it? Thanks in advance! 🙂 |
|
robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Mar 1, 2024
…ypes Steps to Reproduce : - install sales, stock modules - go to products and create new - select product type as Event Ticket,Event Booth or Gift Card - Landed cost boolean is suppose to be visible for a service type product under purchase. Issue : - Landed cost boolean is suppose to be visible for a service type product under purchase, But currently it is visible on other type of products specific to other models like event tickets, event booths etc. Cause: - In product Module there are two Selection fields like detailed_type and type. The detailed_type Selection field contain service, consumable, event booths, event tickets, storable product And the type selection field contains service, consumable, storable product - In xml views for that landed cost boolean the invisible attribute contains the condition like type != service, because of this the landed cost boolean is visible for the product type of event tickets, event booths and gift Cards. Solution: - if we use detailed_type instead of type selection field, then the landed cost boolean field will be invisible on other product types. task- 3725202 closes #153371 Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
This was referenced Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to Reproduce :
Issue :
Cause:
Solution:
task- 3725202
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr