Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] stock_landed_costs: landed Cost to be hidden on other product types #156038

Conversation

fw-bot
Copy link
Contributor

@fw-bot fw-bot commented Mar 1, 2024

Steps to Reproduce :

  • install sales, stock modules
  • go to products and create new
  • select product type as Event Ticket,Event Booth or Gift Card
  • Landed cost boolean is suppose to be visible for a service type product under purchase.

Issue :

  • Landed cost boolean is suppose to be visible for a service type product under purchase, But currently it is visible on other type of products specific to other models like event tickets, event booths etc.

Cause:

  • In product Module there are two Selection fields like detailed_type and type. The detailed_type Selection field contain service, consumable, event booths, event tickets, storable product And the type selection field contains service, consumable, storable product
  • In xml views for that landed cost boolean the invisible attribute contains the condition like type != service, because of this the landed cost boolean is visible for the product type of event tickets, event booths and gift Cards.

Solution:

  • if we use detailed_type instead of type selection field, then the landed cost boolean field will be invisible on other product types.

task- 3725202

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:


I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: #153371

…ypes

Steps to Reproduce :
- install sales, stock modules
- go to products and create new
- select product type as Event Ticket,Event Booth or Gift Card
- Landed cost boolean is suppose to be visible for a service type product under
  purchase.

Issue :
- Landed cost boolean is suppose to be visible for a service type product under
  purchase, But currently it is visible on other type of products specific to
  other models like event tickets, event booths etc.

Cause:
- In product Module there are two Selection fields like detailed_type and
  type. The detailed_type Selection field contain service, consumable,
  event booths, event tickets, storable product  And the type selection field
  contains service, consumable, storable product
- In xml views for that landed cost boolean the invisible  attribute contains
  the condition like  type != service, because of this the landed cost boolean
  is visible for the product type of event tickets, event booths and gift Cards.

Solution:
- if we use detailed_type instead of type selection field, then the landed cost
  boolean field  will be invisible on other product types.

 task- 3725202

X-original-commit: 6ff6b20
@robodoo
Copy link
Contributor

robodoo commented Mar 1, 2024

@fw-bot
Copy link
Contributor Author

fw-bot commented Mar 1, 2024

This PR targets saas-15.2 and is part of the forward-port chain. Further PRs will be created up to master.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@robodoo robodoo added the forwardport This PR was created by @fw-bot label Mar 1, 2024
@C3POdoo C3POdoo added the RD research & development, internal work label Mar 1, 2024
robodoo pushed a commit that referenced this pull request Mar 1, 2024
…ypes

Steps to Reproduce :
- install sales, stock modules
- go to products and create new
- select product type as Event Ticket,Event Booth or Gift Card
- Landed cost boolean is suppose to be visible for a service type product under
  purchase.

Issue :
- Landed cost boolean is suppose to be visible for a service type product under
  purchase, But currently it is visible on other type of products specific to
  other models like event tickets, event booths etc.

Cause:
- In product Module there are two Selection fields like detailed_type and
  type. The detailed_type Selection field contain service, consumable,
  event booths, event tickets, storable product  And the type selection field
  contains service, consumable, storable product
- In xml views for that landed cost boolean the invisible  attribute contains
  the condition like  type != service, because of this the landed cost boolean
  is visible for the product type of event tickets, event booths and gift Cards.

Solution:
- if we use detailed_type instead of type selection field, then the landed cost
  boolean field  will be invisible on other product types.

 task- 3725202

closes #156038

X-original-commit: 6ff6b20
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
@robodoo robodoo closed this Mar 1, 2024
@fw-bot fw-bot deleted the saas-15.2-15.0-bug-fixes-stock-landed-costs-suth-3DaV-fw branch March 15, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forwardport This PR was created by @fw-bot RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants