[FIX] core: post_load default value should be same as *_init_hook #154316
Conversation
C3POdoo
requested review from
a team,
rco-odoo and
HydrionBurst
and removed request for
a team
duong77476-viindoo
force-pushed
the
v17_fix_test_lint
branch
from
c823184
to
c7969f6
Compare
|
Dear @HydrionBurst Can you take a look |
|
summon @Julien00859 |
|
Dear Mr @Julien00859 Can you reply to the summon call of Mr @HydrionBurst please 🥺 |
|
Hi @Julien00859 How are you sir ? Can you take a look ? |
|
@Julien00859 Hi sir, can you have a look ? |
|
Hello @duong77476-viindoo sorry I was on holiday last week. I'm looking at it now 👍 |
|
Thank you for your contribution, do you mind re-targeting your fix on 15.0? (you can keep this branch/pr, just reset it on 15.0 and change the target) |
duong77476-viindoo
force-pushed
the
v17_fix_test_lint
branch
from
c7969f6
to
0b85cad
Compare
Done sir, but v15.0 seem doesn't have the test to check, so probably when r+ someone will need to handle conflict and fix i guest |
| @@ -341,7 +341,7 @@ def load_information_from_description_file(module, mod_path=None): | |||
| 'description': '', | |||
| 'icon': get_module_icon(module), | |||
| 'installable': True, | |||
| 'post_load': None, | |||
| 'post_load': '', | |||
There was a problem hiding this comment.
I search across v15 , i notice this only :v
duong77476-viindoo
force-pushed
the
v17_fix_test_lint
branch
from
0b85cad
to
7ffc63c
Compare
-Step to reproduce: add a post_load method in the init of any module, specify in the manifest like : 'post_load': 'post_load'. in v16 or above Run test_manifests of the test_lint module and we will get warning
duong77476-viindoo
force-pushed
the
v17_fix_test_lint
branch
from
d790dc1
to
21188c0
Compare
Yes, I'll handle the forward-port, don't worry :) @robodoo r+ |
-Step to reproduce: add a post_load method in the init of any module, specify in the manifest like : 'post_load': 'post_load'. in v16 or above Run test_manifests of the test_lint module and we will get warning closes #154316 Signed-off-by: Julien Castiaux (juc) <juc@odoo.com>
3 similar comments
|
@duong77476-viindoo @Julien00859 this pull request has forward-port PRs awaiting action (not merged or closed): |
-Step to reproduce: add a post_load method in the init of any module, specify in the manifest like : 'post_load': 'post_load'. Run test_manifests of the test_lint module and we will get warning
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr