Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] core: post_load default value should be same as *_init_hook #156347

Closed

Conversation

fw-bot
Copy link
Contributor

@fw-bot fw-bot commented Mar 4, 2024

-Step to reproduce: add a post_load method in the init of any module, specify in the manifest like : 'post_load': 'post_load'. Run test_manifests of the test_lint module and we will get warning

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:


I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: #154316

@robodoo
Copy link
Contributor

robodoo commented Mar 4, 2024

@fw-bot
Copy link
Contributor Author

fw-bot commented Mar 4, 2024

@duong77476-viindoo @Julien00859 cherrypicking of pull request #154316 failed.

stdout:

Auto-merging odoo/modules/module.py
CONFLICT (content): Merge conflict in odoo/modules/module.py

stderr:

16:27:39.983546 git.c:463               trace: built-in: git cherry-pick 21188c0e4f8e90965573c076169dee7e017c7af1
error: could not apply 21188c0e4f8e... [FIX] core: post_load default value should be same as *_init_hook
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
----------
status:

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

⚠️ after resolving this conflict, you will need to merge it via @robodoo.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@robodoo robodoo added forwardport This PR was created by @fw-bot conflict There was an error while creating this forward-port PR labels Mar 4, 2024
@C3POdoo C3POdoo added the RD research & development, internal work label Mar 4, 2024
-Step to reproduce: add a post_load method in the init of any module,
specify in the manifest like : 'post_load': 'post_load'. in v16 or above
Run
test_manifests of the test_lint module and we will get warning

X-original-commit: 83e72db
@Julien00859 Julien00859 force-pushed the saas-15.2-v17_fix_test_lint-I793-fw branch from 7e9c3b9 to 2f0c30d Compare March 5, 2024 10:40
Copy link
Member

@Julien00859 Julien00859 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conflict There was an error while creating this forward-port PR forwardport This PR was created by @fw-bot RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants