[FW][FIX] account_group: Avoid parent_id recursion #155451
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BHanq @william-andre cherrypicking of pull request #150171 failed. stdout: stderr: Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?). In the former case, you may want to edit this PR message as well. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
robodoo
added
forwardport
BHanq
force-pushed
the
16.0-15.0-account_account_report_cyclic_group_hierarchy-beha-H-IM-fw
branch
from
e5fe39e
to
e753a35
Compare
Issue: Infinite loop in Trial Balance. Analyze: The infinite loop is due to account_reports.models.account_report.AccountReport.get_account_codes `while group:` loop if a recursion exist in group.parent_id there is an infinite loop. Fix: Ensure the no recursion constrains on parent_id in account_reports. Related task: opw-3665256 X-original-commit: a084666
BHanq
force-pushed
the
16.0-15.0-account_account_report_cyclic_group_hierarchy-beha-H-IM-fw
branch
from
e753a35
to
b8032fe
Compare
|
robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Mar 4, 2024
Issue: Infinite loop in Trial Balance. Analyze: The infinite loop is due to account_reports.models.account_report.AccountReport.get_account_codes `while group:` loop if a recursion exist in group.parent_id there is an infinite loop. Fix: Ensure the no recursion constrains on parent_id in account_reports. Related task: opw-3665256 closes #155451 X-original-commit: a084666 Signed-off-by: William André (wan) <wan@odoo.com> Signed-off-by: Benjamin Hanquin (beha) <beha@odoo.com>
gamarino
pushed a commit
to numaes/numa-public-odoo
that referenced
this pull request
Mar 9, 2024
Issue: Infinite loop in Trial Balance. Analyze: The infinite loop is due to account_reports.models.account_report.AccountReport.get_account_codes `while group:` loop if a recursion exist in group.parent_id there is an infinite loop. Fix: Ensure the no recursion constrains on parent_id in account_reports. Related task: opw-3665256 closes odoo/odoo#155451 X-original-commit: a084666ddaa8c6dcc941f47d7edfaaffb53de8df Signed-off-by: William André (wan) <wan@odoo.com> Signed-off-by: Benjamin Hanquin (beha) <beha@odoo.com>
fw-bot
deleted the
16.0-15.0-account_account_report_cyclic_group_hierarchy-beha-H-IM-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Infinite loop in Trial Balance.
Analyze:
The infinite loop is due to
account_reports.models.account_report.AccountReport.get_account_codes
while group:loop if a recursion exist in group.parent_id there is an infinite loop.Fix:
Ensure the no recursion constrains on parent_id in account_reports.
Related tasks:
opw-3665256
opw-3700368
Forward-Port-Of: #150171