Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] account_group: Avoid parent_id recursion #156321

Conversation

fw-bot
Copy link
Contributor

@fw-bot fw-bot commented Mar 4, 2024

Issue:

Infinite loop in Trial Balance.

Analyze:

The infinite loop is due to
account_reports.models.account_report.AccountReport.get_account_codes while group: loop if a recursion exist in group.parent_id there is an infinite loop.

Fix:

Ensure the no recursion constrains on parent_id in account_reports.

Related tasks:

opw-3665256
opw-3700368

Forward-Port-Of: #155451
Forward-Port-Of: #150171

@robodoo
Copy link
Contributor

robodoo commented Mar 4, 2024

@fw-bot
Copy link
Contributor Author

fw-bot commented Mar 4, 2024

@BHanq @william-andre cherrypicking of pull request #150171 failed.

stdout:

Auto-merging addons/account/i18n/account.pot
Auto-merging addons/account/models/account_account.py
CONFLICT (content): Merge conflict in addons/account/models/account_account.py

stderr:

14:55:03.252645 git.c:463               trace: built-in: git cherry-pick b8032fed5a0540f3fd2e6e75d683f1f1c69bd224
error: could not apply b8032fed5a05... [FIX] account_group: Avoid parent_id recursion
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
----------
status:

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

⚠️ after resolving this conflict, you will need to merge it via @robodoo.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@C3POdoo C3POdoo added the OE the report is linked to a support ticket (opw-...) label Mar 4, 2024
@robodoo robodoo added forwardport This PR was created by @fw-bot conflict There was an error while creating this forward-port PR labels Mar 4, 2024
Issue:
Infinite loop in Trial Balance.

Analyze:
The infinite loop is due to
account_reports.models.account_report.AccountReport.get_account_codes
`while group:` loop if a recursion exist in group.parent_id there is an
infinite loop.

Fix:
Ensure the no recursion constrains on parent_id in account_reports.

Related task:
opw-3665256

X-original-commit: b57bc9c
@BHanq BHanq force-pushed the saas-16.2-15.0-account_account_report_cyclic_group_hierarchy-beha-ePZj-fw branch from 24c7747 to 4d733de Compare March 4, 2024 14:04
@BHanq
Copy link

BHanq commented Mar 4, 2024

robodoo r+

robodoo pushed a commit that referenced this pull request Mar 4, 2024
Issue:
Infinite loop in Trial Balance.

Analyze:
The infinite loop is due to
account_reports.models.account_report.AccountReport.get_account_codes
`while group:` loop if a recursion exist in group.parent_id there is an
infinite loop.

Fix:
Ensure the no recursion constrains on parent_id in account_reports.

Related task:
opw-3665256

closes #156321

X-original-commit: b57bc9c
Signed-off-by: William André (wan) <wan@odoo.com>
Signed-off-by: Benjamin Hanquin (beha) <beha@odoo.com>
@robodoo robodoo closed this Mar 4, 2024
@fw-bot fw-bot deleted the saas-16.2-15.0-account_account_report_cyclic_group_hierarchy-beha-ePZj-fw branch March 18, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conflict There was an error while creating this forward-port PR forwardport This PR was created by @fw-bot OE the report is linked to a support ticket (opw-...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants