Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] base_import : need xlrd to import excel #15644

Closed
wants to merge 1 commit into from
Closed

[FIX] base_import : need xlrd to import excel #15644

wants to merge 1 commit into from

Conversation

fmdl
Copy link
Contributor

@fmdl fmdl commented Feb 26, 2017

Description of the issue/feature this PR addresses:
Need xlrd to import excel
Work on runbot, but not in local

Current behavior before PR:
Import preview failed due to: Unable to load "xlsx" file: requires Python module "xlrd >= 0.8".

Desired behavior after PR is merged:

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@mart-e
Copy link
Contributor

mart-e commented Feb 27, 2017

Hello,

I let @sle-odoo the final word but I don't think this is correct.
The requirements.txt is for the minimum packages for Odoo to work. If you do not have xlrd, Odoo will still work without crashing, it is just that some features will not be available, like the import of xlsx files.
Just install the xlrd package to make it work locally.

@mart-e mart-e added the Blocked will not be processed until a blocking point is resolved label Feb 27, 2017
@fmdl
Copy link
Contributor Author

fmdl commented Mar 12, 2017

I understand. Regards

@fmdl fmdl closed this Mar 12, 2017
@mart-e
Copy link
Contributor

mart-e commented Mar 13, 2017

The "blocked" status does not mean "no", it is just that I needed info before merging it.
After discussion with @sle-odoo adding it in requirements.txt is actually fine. Seems that what I was saying is for the setup file, not requirements.

Merged at 0ac303d

mart-e pushed a commit that referenced this pull request Mar 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocked will not be processed until a blocking point is resolved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants