[FW][FIX] website: restore default checked value for form radio buttons #156818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Same fix as for checkbox (commit [1]) and select (commit [2]). The radio buttons were forgotten. Check commit [1] for in-depth explanation, but this is basically because since the qweb engine conversion to OWL (done at [3]), it would toggle the internal `checked` value and not the `checked` attribute anymore. [1]: odoo@b42e9cc [2]: odoo@dd50481 [3]: odoo#130467 opw-3755078 X-original-commit: d683947
|
|
|
@rdeodoo @robinlej this PR targets master and is the last of the forward-port chain containing: To merge the full chain, use
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
@fw-bot r+ |
robodoo
pushed a commit
that referenced
this pull request
Mar 7, 2024
Same fix as for checkbox (commit [1]) and select (commit [2]). The radio buttons were forgotten. Check commit [1] for in-depth explanation, but this is basically because since the qweb engine conversion to OWL (done at [3]), it would toggle the internal `checked` value and not the `checked` attribute anymore. [1]: b42e9cc [2]: dd50481 [3]: #130467 opw-3755078 closes #156818 X-original-commit: d683947 Signed-off-by: Robin Lejeune (role) <role@odoo.com>
robinlej
deleted the
master-17.0-fix-checked-owl-convert-form-rde-vnzQ-fw
branch
MohammedBasioni
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Mar 8, 2024
Same fix as for checkbox (commit [1]) and select (commit [2]). The radio buttons were forgotten. Check commit [1] for in-depth explanation, but this is basically because since the qweb engine conversion to OWL (done at [3]), it would toggle the internal `checked` value and not the `checked` attribute anymore. [1]: odoo@b42e9cc [2]: odoo@dd50481 [3]: odoo#130467 opw-3755078 closes odoo#156818 X-original-commit: d683947 Signed-off-by: Robin Lejeune (role) <role@odoo.com>
thle-odoo
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Mar 8, 2024
Same fix as for checkbox (commit [1]) and select (commit [2]). The radio buttons were forgotten. Check commit [1] for in-depth explanation, but this is basically because since the qweb engine conversion to OWL (done at [3]), it would toggle the internal `checked` value and not the `checked` attribute anymore. [1]: odoo@b42e9cc [2]: odoo@dd50481 [3]: odoo#130467 opw-3755078 closes odoo#156818 X-original-commit: d683947 Signed-off-by: Robin Lejeune (role) <role@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same fix as for checkbox (commit 1) and select (commit 2). The radio buttons were forgotten.
Check commit 1 for in-depth explanation, but this is basically because since the qweb engine conversion to OWL (done at 3), it would toggle the internal
checkedvalue and not thecheckedattribute anymore.opw-3755078
Forward-Port-Of: #156666