[FW][FIX] l10n_de_skr03: fiscal positions with VAT id should be vat_required #156934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@lase-odoo @FlorianGilbert cherrypicking of pull request #156444 failed. stdout: stderr: Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?). In the former case, you may want to edit this PR message as well. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
robodoo
added
forwardport
lase-odoo
force-pushed
the
saas-16.3-15.0-opw-3721912-german_partner_VAT_required-lase-joR4-fw
branch
from
bed3966
to
c4f0bfd
Compare
|
The conflict was caused by the fact that the data file used to be a an xml: account_tax_fiscal_position_data.xml and is now a csv file. The change on the record is the same. |
Steps to reproduce: - Install the l10n_de package - Create and select a german company - Accounting > Configuration > Settings > Fiscal localization - Set: Deutscher Kontenplan SKR03 for the fiscal localization - Accounting > Configuration > Accounting > Fiscal Positions - Click on "Geschäftspartner EU (mit USt-ID)" (this fiscal position translates to "Business partner EU (with VAT ID)". Issue: The `vat_required` field of this fiscal position is False but sould be True as the fiscal position is "(with VAT id)". Cause of the issue: The `vat_required` field is a Boolean of the account.fiscal.position model without defaut value nor compute method. As such it is interpreted as "False" when unset (just like any unset python boolean). Since the `vat_required` field is not set in the data file of the `l10n_de_skr03` localization for the "Geschäftspartner EU (mit USt-ID)" fiscal position, it will be interpreted as False. Fix: We update the data file of the fiscal localization to the expected value opw-3721912 X-original-commit: 3e320ff
lase-odoo
force-pushed
the
saas-16.3-15.0-opw-3721912-german_partner_VAT_required-lase-joR4-fw
branch
from
c4f0bfd
to
771f4f7
Compare
robodoo
pushed a commit
that referenced
this pull request
Mar 8, 2024
Steps to reproduce: - Install the l10n_de package - Create and select a german company - Accounting > Configuration > Settings > Fiscal localization - Set: Deutscher Kontenplan SKR03 for the fiscal localization - Accounting > Configuration > Accounting > Fiscal Positions - Click on "Geschäftspartner EU (mit USt-ID)" (this fiscal position translates to "Business partner EU (with VAT ID)". Issue: The `vat_required` field of this fiscal position is False but sould be True as the fiscal position is "(with VAT id)". Cause of the issue: The `vat_required` field is a Boolean of the account.fiscal.position model without defaut value nor compute method. As such it is interpreted as "False" when unset (just like any unset python boolean). Since the `vat_required` field is not set in the data file of the `l10n_de_skr03` localization for the "Geschäftspartner EU (mit USt-ID)" fiscal position, it will be interpreted as False. Fix: We update the data file of the fiscal localization to the expected value opw-3721912 closes #156934 X-original-commit: 3e320ff Signed-off-by: Florian Gilbert (flg) <flg@odoo.com>
This was referenced Mar 8, 2024
fw-bot
deleted the
saas-16.3-15.0-opw-3721912-german_partner_VAT_required-lase-joR4-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to reproduce:
Issue: The
vat_requiredfield of this fiscal position is False but sould be True as the fiscal position is "(with VAT id)".Cause of the issue:
The
vat_requiredfield is a Boolean of the account.fiscal.position model without defaut value nor compute method. As such it is interpreted as "False" when unset (just like any unset python boolean). Since thevat_requiredfield is not set in the data file of thel10n_de_skr03localization for the "Geschäftspartner EU (mit USt-ID)" fiscal position, it will be interpreted as False.Fix:
We update the data file of the fiscal localization to the expected value
opw-3721912
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: #156652
Forward-Port-Of: #156444