[FW][FIX] l10n_de_skr03: fiscal positions with VAT id should be vat_required #157044
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to reproduce:
Issue: The
vat_required
field of this fiscal position is False but sould be True as the fiscal position is "(with VAT id)".Cause of the issue:
The
vat_required
field is a Boolean of the account.fiscal.position model without defaut value nor compute method. As such it is interpreted as "False" when unset (just like any unset python boolean). Since thevat_required
field is not set in the data file of thel10n_de_skr03
localization for the "Geschäftspartner EU (mit USt-ID)" fiscal position, it will be interpreted as False.Fix:
We update the data file of the fiscal localization to the expected value
opw-3721912
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: #156934
Forward-Port-Of: #156444