[FIX] pos_restaurant: don't clear order after printing bill #158516

AH-Yussef · 2024-03-21T09:02:15Z

Steps to reproduce:

Install Restaurant app.
Go to Point of Sale app and open a new Restaurant session.
Add items to the order.
Click on the Bill button, the receipt window appears.
Click on the Print button, the print window appears. Cancel it - U don't have to print it or save it-.
Close the receipt window.
Add another item to the order, the older items are removed -the order is cleared-.

Investigation:

When the Print button is clicked in the Bill Screen, print() method is triggered

odoo/addons/pos_restaurant/static/src/app/bill_screen/bill_screen.js

Lines 16 to 19 in c3fe6df

    
           print() { 
        
               this.pos.printReceipt(); 
        
               this.pos.get_order()._printed = false; 
        
           }

which do two actions simultaneously:
- calls the printReceipt() method
  
  odoo/addons/pos_restaurant/static/src/app/bill_screen/bill_screen.js
  
  Line 17 in c3fe6df
  
  this.pos.printReceipt();
- set the order._printed to false
  
  odoo/addons/pos_restaurant/static/src/app/bill_screen/bill_screen.js
  
  Line 18 in c3fe6df
  
  this.pos.get_order()._printed = false;
  
  NOW order._printed IS FALSE.
Inside the printReceipt() method, we reach this line

odoo/addons/point_of_sale/static/src/app/store/pos_store.js

Line 1793 in c3fe6df

this.get_order()._printed = true;

which set the order._printed to True. NOW order._printed IS TRUE.

When a new product is added to the order, this if clause

odoo/addons/point_of_sale/static/src/app/store/models.js

Lines 1871 to 1875 in c3fe6df

    
           if (this._printed) { 
        
               // when adding product with a barcode while being in receipt screen 
        
               this.pos.removeOrder(this); 
        
               return this.pos.add_new_order().add_product(product, options); 
        
           }

is activated given that the order._printed is true although it should have been false!

opw-3796605

Steps to reproduce: - Install Restaurant app. - Go to Point of Sale app and open a new Restaurant session. - Add items to the order. - Click on the Bill button, the reeceipt window appears. - Click on the Print button, the print window appears. Cancel it - U don't have to print it or save it-. - Close the reeceipt window. - Add another item to the order, the older items are removed -the order is cleared-. Investigation: - When the Print button is clicked in the Bill Screen, `print()` method is triggered https://github.com/odoo/odoo/blob/c3fe6dfd3c56ae8058d0eb688680bdc627ee611a/addons/pos_restaurant/static/src/app/bill_screen/bill_screen.js#L16-L19 - which do two actions simultaneously: - calls the `printReceipt()` method https://github.com/odoo/odoo/blob/c3fe6dfd3c56ae8058d0eb688680bdc627ee611a/addons/pos_restaurant/static/src/app/bill_screen/bill_screen.js#L17 - set the order.`_printed` to `false` https://github.com/odoo/odoo/blob/c3fe6dfd3c56ae8058d0eb688680bdc627ee611a/addons/pos_restaurant/static/src/app/bill_screen/bill_screen.js#L18 NOW order.`_printed` IS FALSE. - Inside the `printReceipt()` method, we reach this line https://github.com/odoo/odoo/blob/c3fe6dfd3c56ae8058d0eb688680bdc627ee611a/addons/point_of_sale/static/src/app/store/pos_store.js#L1793 which set the order.`_printed` to True. NOW order.`_printed` IS TRUE. - When a new product is added to the order, this if clause https://github.com/odoo/odoo/blob/c3fe6dfd3c56ae8058d0eb688680bdc627ee611a/addons/point_of_sale/static/src/app/store/models.js#L1871-L1875 is activated given that the order.`_printed` is true although it should have been false! opw-3796605

robodoo · 2024-03-21T09:02:50Z

Pull request status dashboard.

robinengels

LGTM, could you add a test ? I think it should not be to difficult. Don't hesitate to ask me if you need help

AH-Yussef · 2024-03-22T14:05:50Z

The explained behavior can't be tested!

Because an essential step is to Click on the Print button of the Bill screen, which opens the Browser print popup which can't be automatically closed by the test engine!

That results in the flow being stuck at the printReceipt method.

caburj

robodoo r+

Steps to reproduce: - Install Restaurant app. - Go to Point of Sale app and open a new Restaurant session. - Add items to the order. - Click on the Bill button, the reeceipt window appears. - Click on the Print button, the print window appears. Cancel it - U don't have to print it or save it-. - Close the reeceipt window. - Add another item to the order, the older items are removed -the order is cleared-. Investigation: - When the Print button is clicked in the Bill Screen, `print()` method is triggered https://github.com/odoo/odoo/blob/c3fe6dfd3c56ae8058d0eb688680bdc627ee611a/addons/pos_restaurant/static/src/app/bill_screen/bill_screen.js#L16-L19 - which do two actions simultaneously: - calls the `printReceipt()` method https://github.com/odoo/odoo/blob/c3fe6dfd3c56ae8058d0eb688680bdc627ee611a/addons/pos_restaurant/static/src/app/bill_screen/bill_screen.js#L17 - set the order.`_printed` to `false` https://github.com/odoo/odoo/blob/c3fe6dfd3c56ae8058d0eb688680bdc627ee611a/addons/pos_restaurant/static/src/app/bill_screen/bill_screen.js#L18 NOW order.`_printed` IS FALSE. - Inside the `printReceipt()` method, we reach this line https://github.com/odoo/odoo/blob/c3fe6dfd3c56ae8058d0eb688680bdc627ee611a/addons/point_of_sale/static/src/app/store/pos_store.js#L1793 which set the order.`_printed` to True. NOW order.`_printed` IS TRUE. - When a new product is added to the order, this if clause https://github.com/odoo/odoo/blob/c3fe6dfd3c56ae8058d0eb688680bdc627ee611a/addons/point_of_sale/static/src/app/store/models.js#L1871-L1875 is activated given that the order.`_printed` is true although it should have been false! opw-3796605 closes #158516 Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>

fw-bot · 2024-03-31T05:53:44Z