[FW][FIX] pos_restaurant: don't clear order after printing bill #159530

fw-bot · 2024-03-27T17:17:30Z

Steps to reproduce:

Install Restaurant app.
Go to Point of Sale app and open a new Restaurant session.
Add items to the order.
Click on the Bill button, the receipt window appears.
Click on the Print button, the print window appears. Cancel it - U don't have to print it or save it-.
Close the receipt window.
Add another item to the order, the older items are removed -the order is cleared-.

Investigation:

When the Print button is clicked in the Bill Screen, print() method is triggered

odoo/addons/pos_restaurant/static/src/app/bill_screen/bill_screen.js

Lines 16 to 19 in c3fe6df

    
           print() { 
        
               this.pos.printReceipt(); 
        
               this.pos.get_order()._printed = false; 
        
           }

which do two actions simultaneously:
- calls the printReceipt() method
  
  odoo/addons/pos_restaurant/static/src/app/bill_screen/bill_screen.js
  
  Line 17 in c3fe6df
  
  this.pos.printReceipt();
- set the order._printed to false
  
  odoo/addons/pos_restaurant/static/src/app/bill_screen/bill_screen.js
  
  Line 18 in c3fe6df
  
  this.pos.get_order()._printed = false;
  
  NOW order._printed IS FALSE.
Inside the printReceipt() method, we reach this line

odoo/addons/point_of_sale/static/src/app/store/pos_store.js

Line 1793 in c3fe6df

this.get_order()._printed = true;

which set the order._printed to True. NOW order._printed IS TRUE.

When a new product is added to the order, this if clause

odoo/addons/point_of_sale/static/src/app/store/models.js

Lines 1871 to 1875 in c3fe6df

    
           if (this._printed) { 
        
               // when adding product with a barcode while being in receipt screen 
        
               this.pos.removeOrder(this); 
        
               return this.pos.add_new_order().add_product(product, options); 
        
           }

is activated given that the order._printed is true although it should have been false!

opw-3796605

Forward-Port-Of: #158516

robodoo · 2024-03-27T17:18:18Z

Pull request status dashboard.

fw-bot · 2024-03-27T17:18:18Z

@AH-Yussef @caburj this PR targets master and is the last of the forward-port chain containing:

[FW][FIX] pos_restaurant: don't clear order after printing bill #159503

To merge the full chain, use

@fw-bot r+

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

AH-Yussef · 2024-03-28T09:40:56Z

@fw-bot r+

Steps to reproduce: - Install Restaurant app. - Go to Point of Sale app and open a new Restaurant session. - Add items to the order. - Click on the Bill button, the reeceipt window appears. - Click on the Print button, the print window appears. Cancel it - U don't have to print it or save it-. - Close the reeceipt window. - Add another item to the order, the older items are removed -the order is cleared-. Investigation: - When the Print button is clicked in the Bill Screen, `print()` method is triggered https://github.com/odoo/odoo/blob/c3fe6dfd3c56ae8058d0eb688680bdc627ee611a/addons/pos_restaurant/static/src/app/bill_screen/bill_screen.js#L16-L19 - which do two actions simultaneously: - calls the `printReceipt()` method https://github.com/odoo/odoo/blob/c3fe6dfd3c56ae8058d0eb688680bdc627ee611a/addons/pos_restaurant/static/src/app/bill_screen/bill_screen.js#L17 - set the order.`_printed` to `false` https://github.com/odoo/odoo/blob/c3fe6dfd3c56ae8058d0eb688680bdc627ee611a/addons/pos_restaurant/static/src/app/bill_screen/bill_screen.js#L18 NOW order.`_printed` IS FALSE. - Inside the `printReceipt()` method, we reach this line https://github.com/odoo/odoo/blob/c3fe6dfd3c56ae8058d0eb688680bdc627ee611a/addons/point_of_sale/static/src/app/store/pos_store.js#L1793 which set the order.`_printed` to True. NOW order.`_printed` IS TRUE. - When a new product is added to the order, this if clause https://github.com/odoo/odoo/blob/c3fe6dfd3c56ae8058d0eb688680bdc627ee611a/addons/point_of_sale/static/src/app/store/models.js#L1871-L1875 is activated given that the order.`_printed` is true although it should have been false! opw-3796605 closes #159530 X-original-commit: 37ce3e5 Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com> Signed-off-by: Ali Hassan Youssef (alhy) <alhy@odoo.com>

robodoo · 2024-03-30T14:12:33Z

@AH-Yussef @caburj staging failed: ci/runbot (view more at https://runbot.odoo.com/runbot/build/60617760)

fw-bot · 2024-04-01T03:11:59Z

@AH-Yussef @caburj this PR was modified / updated and has become a normal PR. It should be merged the normal way (via @robodoo)

AH-Yussef · 2024-04-01T03:12:01Z

@robodoo r+

Steps to reproduce: - Install Restaurant app. - Go to Point of Sale app and open a new Restaurant session. - Add items to the order. - Click on the Bill button, the reeceipt window appears. - Click on the Print button, the print window appears. Cancel it - U don't have to print it or save it-. - Close the reeceipt window. - Add another item to the order, the older items are removed -the order is cleared-. Investigation: - When the Print button is clicked in the Bill Screen, `print()` method is triggered https://github.com/odoo/odoo/blob/c3fe6dfd3c56ae8058d0eb688680bdc627ee611a/addons/pos_restaurant/static/src/app/bill_screen/bill_screen.js#L16-L19 - which do two actions simultaneously: - calls the `printReceipt()` method https://github.com/odoo/odoo/blob/c3fe6dfd3c56ae8058d0eb688680bdc627ee611a/addons/pos_restaurant/static/src/app/bill_screen/bill_screen.js#L17 - set the order.`_printed` to `false` https://github.com/odoo/odoo/blob/c3fe6dfd3c56ae8058d0eb688680bdc627ee611a/addons/pos_restaurant/static/src/app/bill_screen/bill_screen.js#L18 NOW order.`_printed` IS FALSE. - Inside the `printReceipt()` method, we reach this line https://github.com/odoo/odoo/blob/c3fe6dfd3c56ae8058d0eb688680bdc627ee611a/addons/point_of_sale/static/src/app/store/pos_store.js#L1793 which set the order.`_printed` to True. NOW order.`_printed` IS TRUE. - When a new product is added to the order, this if clause https://github.com/odoo/odoo/blob/c3fe6dfd3c56ae8058d0eb688680bdc627ee611a/addons/point_of_sale/static/src/app/store/models.js#L1871-L1875 is activated given that the order.`_printed` is true although it should have been false! opw-3796605 X-original-commit: 37ce3e5

AH-Yussef · 2024-04-04T13:51:00Z

@robodoo r+

Steps to reproduce: - Install Restaurant app. - Go to Point of Sale app and open a new Restaurant session. - Add items to the order. - Click on the Bill button, the reeceipt window appears. - Click on the Print button, the print window appears. Cancel it - U don't have to print it or save it-. - Close the reeceipt window. - Add another item to the order, the older items are removed -the order is cleared-. Investigation: - When the Print button is clicked in the Bill Screen, `print()` method is triggered https://github.com/odoo/odoo/blob/c3fe6dfd3c56ae8058d0eb688680bdc627ee611a/addons/pos_restaurant/static/src/app/bill_screen/bill_screen.js#L16-L19 - which do two actions simultaneously: - calls the `printReceipt()` method https://github.com/odoo/odoo/blob/c3fe6dfd3c56ae8058d0eb688680bdc627ee611a/addons/pos_restaurant/static/src/app/bill_screen/bill_screen.js#L17 - set the order.`_printed` to `false` https://github.com/odoo/odoo/blob/c3fe6dfd3c56ae8058d0eb688680bdc627ee611a/addons/pos_restaurant/static/src/app/bill_screen/bill_screen.js#L18 NOW order.`_printed` IS FALSE. - Inside the `printReceipt()` method, we reach this line https://github.com/odoo/odoo/blob/c3fe6dfd3c56ae8058d0eb688680bdc627ee611a/addons/point_of_sale/static/src/app/store/pos_store.js#L1793 which set the order.`_printed` to True. NOW order.`_printed` IS TRUE. - When a new product is added to the order, this if clause https://github.com/odoo/odoo/blob/c3fe6dfd3c56ae8058d0eb688680bdc627ee611a/addons/point_of_sale/static/src/app/store/models.js#L1871-L1875 is activated given that the order.`_printed` is true although it should have been false! opw-3796605 closes #159530 X-original-commit: 37ce3e5 Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com> Signed-off-by: Ali Hassan Youssef (alhy) <alhy@odoo.com>

Steps to reproduce: - Install Restaurant app. - Go to Point of Sale app and open a new Restaurant session. - Add items to the order. - Click on the Bill button, the reeceipt window appears. - Click on the Print button, the print window appears. Cancel it - U don't have to print it or save it-. - Close the reeceipt window. - Add another item to the order, the older items are removed -the order is cleared-. Investigation: - When the Print button is clicked in the Bill Screen, `print()` method is triggered https://github.com/odoo/odoo/blob/c3fe6dfd3c56ae8058d0eb688680bdc627ee611a/addons/pos_restaurant/static/src/app/bill_screen/bill_screen.js#L16-L19 - which do two actions simultaneously: - calls the `printReceipt()` method https://github.com/odoo/odoo/blob/c3fe6dfd3c56ae8058d0eb688680bdc627ee611a/addons/pos_restaurant/static/src/app/bill_screen/bill_screen.js#L17 - set the order.`_printed` to `false` https://github.com/odoo/odoo/blob/c3fe6dfd3c56ae8058d0eb688680bdc627ee611a/addons/pos_restaurant/static/src/app/bill_screen/bill_screen.js#L18 NOW order.`_printed` IS FALSE. - Inside the `printReceipt()` method, we reach this line https://github.com/odoo/odoo/blob/c3fe6dfd3c56ae8058d0eb688680bdc627ee611a/addons/point_of_sale/static/src/app/store/pos_store.js#L1793 which set the order.`_printed` to True. NOW order.`_printed` IS TRUE. - When a new product is added to the order, this if clause https://github.com/odoo/odoo/blob/c3fe6dfd3c56ae8058d0eb688680bdc627ee611a/addons/point_of_sale/static/src/app/store/models.js#L1871-L1875 is activated given that the order.`_printed` is true although it should have been false! opw-3796605 closes odoo#159530 X-original-commit: 37ce3e5 Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com> Signed-off-by: Ali Hassan Youssef (alhy) <alhy@odoo.com>

robodoo added the forwardport This PR was created by @fw-bot label Mar 27, 2024

C3POdoo added the OE the report is linked to a support ticket (opw-...) label Mar 27, 2024

fw-bot mentioned this pull request Mar 31, 2024

[FIX] pos_restaurant: don't clear order after printing bill #158516

Closed

AH-Yussef force-pushed the master-saas-17.1-opw-3796605-don't_clear_order_after_printing_bill-alhy-tt4R-fw branch from ea7fff7 to 2b278d5 Compare April 1, 2024 03:11

C3POdoo requested review from a team and adgu-odoo and removed request for a team April 1, 2024 03:13

AH-Yussef force-pushed the master-saas-17.1-opw-3796605-don't_clear_order_after_printing_bill-alhy-tt4R-fw branch from 2b278d5 to 566dd53 Compare April 2, 2024 06:41

adgu-odoo requested review from caburj and removed request for adgu-odoo April 2, 2024 08:27

robodoo temporarily deployed to merge April 5, 2024 07:10 Inactive

robodoo closed this Apr 5, 2024

robodoo added the 17.3 label Apr 5, 2024

fw-bot deleted the master-saas-17.1-opw-3796605-don't_clear_order_after_printing_bill-alhy-tt4R-fw branch April 19, 2024 07:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FW][FIX] pos_restaurant: don't clear order after printing bill #159530

[FW][FIX] pos_restaurant: don't clear order after printing bill #159530

fw-bot commented Mar 27, 2024

robodoo commented Mar 27, 2024

fw-bot commented Mar 27, 2024

AH-Yussef commented Mar 28, 2024

robodoo commented Mar 30, 2024

fw-bot commented Apr 1, 2024

AH-Yussef commented Apr 1, 2024

AH-Yussef commented Apr 4, 2024

	print() {
	this.pos.printReceipt();
	this.pos.get_order()._printed = false;
	}

	if (this._printed) {
	// when adding product with a barcode while being in receipt screen
	this.pos.removeOrder(this);
	return this.pos.add_new_order().add_product(product, options);
	}

[FW][FIX] pos_restaurant: don't clear order after printing bill #159530

[FW][FIX] pos_restaurant: don't clear order after printing bill #159530

Conversation

fw-bot commented Mar 27, 2024

Steps to reproduce:

Investigation:

robodoo commented Mar 27, 2024

fw-bot commented Mar 27, 2024

AH-Yussef commented Mar 28, 2024

robodoo commented Mar 30, 2024

fw-bot commented Apr 1, 2024

AH-Yussef commented Apr 1, 2024

AH-Yussef commented Apr 4, 2024