New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMP] web_editor: use esc key to discard crop widget #158543

Closed

adsa-odoo wants to merge 1 commit into odoo:17.0 from odoo-dev:17.0-discard-cropper-on-esc-adsa

Contributor

adsa-odoo commented Mar 21, 2024

Current behaviour before commit:

In website when cropper is open, pressing ESC key
hides side panel.

Desired behaviour after commit:

Now, pressing ESC works same as discard button. It closes
the cropper and prevents hiding side panel.

task-3787411

I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Contributor

robodoo commented Mar 21, 2024

Pull request status dashboard.

C3POdoo added the RD label

deso-odoo reviewed

View reviewed changes

addons/web_editor/static/src/js/wysiwyg/widgets/image_crop.js Outdated Show resolved Hide resolved

adsa-odoo force-pushed the 17.0-discard-cropper-on-esc-adsa branch from bb39b08 to 1661e0b Compare

April 1, 2024 05:03

Contributor Author

adsa-odoo commented Apr 1, 2024

@deso-odoo Done:)


          [IMP] web_editor: use esc key to discard crop widget

2b13158

Current behaviour before commit:

In website when cropper is open, pressing ESC key
hides side panel.

Desired behaviour after commit:

Now, pressing ESC works same as discard button. It
closes the cropper and prevents hiding side panel.

task-3787411

adsa-odoo force-pushed the 17.0-discard-cropper-on-esc-adsa branch from 1661e0b to 2b13158 Compare

April 1, 2024 05:08

deso-odoo marked this pull request as ready for review

April 1, 2024 05:11

C3POdoo requested a review from a team

April 1, 2024 05:12

Contributor

dmo-odoo commented Apr 29, 2024

robodoo closed this in

b008d91

fw-bot mentioned this pull request

[FW][IMP] web_editor: use esc key to discard crop widget #163800

Closed

robodoo temporarily deployed to merge

April 29, 2024 12:15

Inactive

This was referenced Apr 29, 2024

[FW][IMP] web_editor: use esc key to discard crop widget #163818

Closed

[FW][IMP] web_editor: use esc key to discard crop widget #163850

Closed

willylohws pushed a commit to willylohws/odoo that referenced this pull request


          [IMP] web_editor: use esc key to discard crop widget

c8427f4

Current behaviour before commit:

In website when cropper is open, pressing ESC key
hides side panel.

Desired behaviour after commit:

Now, pressing ESC works same as discard button. It
closes the cropper and prevents hiding side panel.

task-3787411

closes odoo#158543

Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>

Contributor

fw-bot commented May 3, 2024

@adsa-odoo @dmo-odoo this pull request has forward-port PRs awaiting action (not merged or closed):

[FW][IMP] web_editor: use esc key to discard crop widget #163800

7 similar comments

Contributor

fw-bot commented May 4, 2024

@adsa-odoo @dmo-odoo this pull request has forward-port PRs awaiting action (not merged or closed):

[FW][IMP] web_editor: use esc key to discard crop widget #163800

Contributor

fw-bot commented May 5, 2024

@adsa-odoo @dmo-odoo this pull request has forward-port PRs awaiting action (not merged or closed):

[FW][IMP] web_editor: use esc key to discard crop widget #163800

Contributor

fw-bot commented May 6, 2024

@adsa-odoo @dmo-odoo this pull request has forward-port PRs awaiting action (not merged or closed):

[FW][IMP] web_editor: use esc key to discard crop widget #163800

Contributor

fw-bot commented May 7, 2024

@adsa-odoo @dmo-odoo this pull request has forward-port PRs awaiting action (not merged or closed):

[FW][IMP] web_editor: use esc key to discard crop widget #163800

Contributor

fw-bot commented May 8, 2024

@adsa-odoo @dmo-odoo this pull request has forward-port PRs awaiting action (not merged or closed):

[FW][IMP] web_editor: use esc key to discard crop widget #163800

Contributor

fw-bot commented May 9, 2024

@adsa-odoo @dmo-odoo this pull request has forward-port PRs awaiting action (not merged or closed):

[FW][IMP] web_editor: use esc key to discard crop widget #163800

Contributor

fw-bot commented May 11, 2024

@adsa-odoo @dmo-odoo this pull request has forward-port PRs awaiting action (not merged or closed):

[FW][IMP] web_editor: use esc key to discard crop widget #163800

fw-bot deleted the 17.0-discard-cropper-on-esc-adsa branch

May 13, 2024 12:46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment