[FW][IMP] web_editor: use esc key to discard crop widget #163800
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR targets saas-17.1 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
@adsa-odoo @dmo-odoo staging failed: ci/documentation on 91e815505027981039315b2b22942da824c67aeb (view more at https://runbot.odoo.com/runbot/build/62016943) |
|
@dmo-odoo Can you please have a look here? |
|
@adsa-odoo I suggest to rebase your branch and force push it to force a rebuild. |
adsa-odoo
force-pushed
the
saas-17.1-17.0-discard-cropper-on-esc-adsa-gvO1-fw
branch
from
c6a1015
to
a553b56
Compare
|
@adsa-odoo @dmo-odoo this PR was modified / updated and has become a normal PR. It should be merged the normal way (via @robodoo) |
|
@robodoo r+ |
Current behaviour before commit: In website when cropper is open, pressing ESC key hides side panel. Desired behaviour after commit: Now, pressing ESC works same as discard button. It closes the cropper and prevents hiding side panel. task-3787411 X-original-commit: b008d91
adsa-odoo
force-pushed
the
saas-17.1-17.0-discard-cropper-on-esc-adsa-gvO1-fw
branch
from
a553b56
to
682012f
Compare
|
@dmo-odoo I think this one needs to be r+ again since it is rebased again. |
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
May 13, 2024
Current behaviour before commit: In website when cropper is open, pressing ESC key hides side panel. Desired behaviour after commit: Now, pressing ESC works same as discard button. It closes the cropper and prevents hiding side panel. task-3787411 closes #163800 X-original-commit: b008d91 Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
May 13, 2024
Current behaviour before commit: In website when cropper is open, pressing ESC key hides side panel. Desired behaviour after commit: Now, pressing ESC works same as discard button. It closes the cropper and prevents hiding side panel. task-3787411 closes #163800 X-original-commit: b008d91 Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current behaviour before commit:
In website when cropper is open, pressing ESC key
hides side panel.
Desired behaviour after commit:
Now, pressing ESC works same as discard button. It closes
the cropper and prevents hiding side panel.
task-3787411
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: #158543