[FIX] base_vat: properly display in context #159332
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C3POdoo
requested review from
a team and
casp-odoo
and removed request for
a team
casp-odoo
requested changes
Apr 3, 2024
There was a problem hiding this comment.
There is something wrong with the current 17.0, but I don't believe that the current fix is the right one.
We shouldn't force a new line, but add some padding instead between the two fields, and it shouldn't be possible to have the checkbox on a different line than its label.
But to avoid wasting space (since the VAT field is never that long), we don't need to always have a new line; only when the screen size asks for it.
What I would suggest is putting the label and the field inside of a <span class="text-nowrap ps-2"/> allowing for
- a dynamic display based on the size of the screen
- enforce the label and the field to always be on the same line
- always keep a minimal space between the vat field and the checkbox field
wtaferner
force-pushed
the
17.0-fix_vies_valid_display-wt
branch
from
c89801c
to
3613a48
Compare
|
@william-andre |
Having the VAT VIES Check valid field directly next to the VAT number as an inline element becomes unreadable, so we wrap it add padding and text-nowrap
wtaferner
force-pushed
the
17.0-fix_vies_valid_display-wt
branch
from
3613a48
to
807da18
Compare
This was referenced Apr 3, 2024
willylohws
pushed a commit
to willylohws/odoo
that referenced
this pull request
May 1, 2024
Having the VAT VIES Check valid field directly next to the VAT number as an inline element becomes unreadable, so we wrap it add padding and text-nowrap closes odoo#159332 Signed-off-by: William André (wan) <wan@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses:
Having the VAT VIES Check valid field directly next to the VAT number as an inline element becomes unreadable, so we add a line break before
Current behavior before PR:
Desired behavior after PR is merged:
Info: @wt-io-it
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr