Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] website_sale: non deterministic test failures #159387

Conversation

fw-bot
Copy link
Contributor

@fw-bot fw-bot commented Mar 26, 2024

Wild try to avoid failures on runbot builds (not reproducible locally).

  • simplify and split tour steps
  • correctly specify check steps as isCheck: true
  • make sure python setup is deterministic
    • batch template creation to avoid creation of dummy archived variant
    • target values for the variant to archive instead of its number in the list of variants

runbot build error 25046


I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: #159270

Wild try to avoid failures on runbot builds (not reproducible locally).

* simplify and split tour steps
* correctly specify check steps as isCheck: true
* make sure python setup is deterministic
  * batch template creation to avoid creation of dummy archived variant
  * target values for the variant to archive instead of its number in the
  list of variants

runbot build error 25046

X-original-commit: 9906785
@robodoo
Copy link
Contributor

robodoo commented Mar 26, 2024

@fw-bot
Copy link
Contributor Author

fw-bot commented Mar 26, 2024

This PR targets saas-17.1 and is part of the forward-port chain. Further PRs will be created up to master.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@robodoo robodoo added the forwardport This PR was created by @fw-bot label Mar 26, 2024
@C3POdoo C3POdoo added the RD research & development, internal work label Mar 26, 2024
@fw-bot
Copy link
Contributor Author

fw-bot commented Mar 26, 2024

@Feyensv the next pull request (#159398) is in conflict. You can merge the chain up to here by saying

@fw-bot r+

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@Feyensv
Copy link
Contributor

Feyensv commented Mar 28, 2024

@fw-bot r+

robodoo pushed a commit that referenced this pull request Mar 28, 2024
Wild try to avoid failures on runbot builds (not reproducible locally).

* simplify and split tour steps
* correctly specify check steps as isCheck: true
* make sure python setup is deterministic
  * batch template creation to avoid creation of dummy archived variant
  * target values for the variant to archive instead of its number in the
  list of variants

runbot build error 25046

closes #159387

X-original-commit: 9906785
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
@robodoo robodoo closed this Mar 28, 2024
@fw-bot fw-bot deleted the saas-17.1-saas-16.4-wsale-runbot-error-vfe-M5mk-fw branch April 11, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forwardport This PR was created by @fw-bot RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants