Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] website_sale: non deterministic test failures #159398

Conversation

fw-bot
Copy link
Contributor

@fw-bot fw-bot commented Mar 26, 2024

Wild try to avoid failures on runbot builds (not reproducible locally).

  • simplify and split tour steps
  • correctly specify check steps as isCheck: true
  • make sure python setup is deterministic
    • batch template creation to avoid creation of dummy archived variant
    • target values for the variant to archive instead of its number in the list of variants

runbot build error 25046


I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: #159270

@robodoo
Copy link
Contributor

robodoo commented Mar 26, 2024

@fw-bot
Copy link
Contributor Author

fw-bot commented Mar 26, 2024

@Feyensv cherrypicking of pull request #159270 failed.

stdout:

Auto-merging addons/website_sale/static/tests/tours/website_sale_shop_archived_variant_multi.js
Auto-merging addons/website_sale/tests/test_customize.py
CONFLICT (content): Merge conflict in addons/website_sale/tests/test_customize.py

stderr:

20:56:00.689855 git.c:463               trace: built-in: git cherry-pick a5acc07d4837bbf21769f19f5f6bffc4283543d6
error: could not apply a5acc07d4837... [FIX] website_sale: non deterministic test failures
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
----------
status:

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

⚠️ after resolving this conflict, you will need to merge it via @robodoo.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@C3POdoo C3POdoo added the RD research & development, internal work label Mar 26, 2024
@robodoo robodoo added forwardport This PR was created by @fw-bot conflict There was an error while creating this forward-port PR labels Mar 26, 2024
Wild try to avoid failures on runbot builds (not reproducible locally).

* simplify and split tour steps
* correctly specify check steps as isCheck: true
* make sure python setup is deterministic
  * batch template creation to avoid creation of dummy archived variant
  * target values for the variant to archive instead of its number in the
  list of variants

runbot build error 25046

X-original-commit: 9906785
@Feyensv Feyensv force-pushed the saas-17.2-saas-16.4-wsale-runbot-error-vfe-6ObX-fw branch from b0b1e36 to d5acabc Compare March 28, 2024 11:12
@Feyensv
Copy link
Contributor

Feyensv commented Mar 28, 2024

@robodoo r+

robodoo pushed a commit that referenced this pull request Mar 28, 2024
Wild try to avoid failures on runbot builds (not reproducible locally).

* simplify and split tour steps
* correctly specify check steps as isCheck: true
* make sure python setup is deterministic
  * batch template creation to avoid creation of dummy archived variant
  * target values for the variant to archive instead of its number in the
  list of variants

runbot build error 25046

closes #159398

X-original-commit: 9906785
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
@robodoo robodoo closed this Mar 28, 2024
@fw-bot fw-bot deleted the saas-17.2-saas-16.4-wsale-runbot-error-vfe-6ObX-fw branch April 11, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conflict There was an error while creating this forward-port PR forwardport This PR was created by @fw-bot RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants