[FIX] web: adapt z-index and dimensions of properties field types #159463
Conversation
abd-msyukyu-odoo
force-pushed
the
saas-17.2-knowledge-fix-popover-zindex-abd
branch
from
d659e5b
to
ad86f41
Compare
C3POdoo
requested review from
a team,
juliusc2066 and
BastienFafchamps
and removed request for
a team
| @@ -62,3 +62,13 @@ | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| .o_field_property_definition_type_popover { | |||
There was a problem hiding this comment.
Can we also fix the dark mode while we're at it?
saas-17.1:
saas-17.2:
I think in the past this was solved by Stéphane with:
https://github.com/odoo/enterprise/blob/master/web_enterprise/static/src/views/fields/properties/properties_field.dark.scss#L2
But it's probably not applied anymore?
To double-check (and clean the old rule if no longer useful).
| width: 20px; | ||
| height: 20px; | ||
| } | ||
| &.popover { |
There was a problem hiding this comment.
Can this be put on the containing rule then? To simplify.
In [1], dropdowns were updated and it impacted the properties field edition: - z-index of the popover opened for the dropdown of a property field type was lower than the element it was opened for, resulting in part of the popover being hidden. - img style (dimensions) was not applied as the dropdown list is now a popover (sibling instead of child), resulting in bigger images. This commit fixes the issue by adding a class on the field type selection popover. [1]: odoo@7b7a261 task-3834506
abd-msyukyu-odoo
force-pushed
the
saas-17.2-knowledge-fix-popover-zindex-abd
branch
from
ad86f41
to
5a5d515
Compare
|
@awa-odoo Thanks for the review! I added an ENT PR for the dark part and updated the code |
|
@robodoo r+ |
In [1], dropdowns were updated and it impacted the properties field edition: - z-index of the popover opened for the dropdown of a property field type was lower than the element it was opened for, resulting in part of the popover being hidden. - img style (dimensions) was not applied as the dropdown list is now a popover (sibling instead of child), resulting in bigger images. This commit fixes the issue by adding a class on the field type selection popover. [1]: 7b7a261 task-3834506 closes #159463 Related: odoo/enterprise#59566 Signed-off-by: Warnon Aurélien (awa) <awa@odoo.com>
|
@abd-msyukyu-odoo @awa-odoo this pull request has forward-port PRs awaiting action (not merged or closed): |
1 similar comment
|
@abd-msyukyu-odoo @awa-odoo this pull request has forward-port PRs awaiting action (not merged or closed): |
In 1, dropdowns were updated and it impacted the properties field edition:
This commit fixes the issue by adding a class on the field type selection popover.
task-3834506