Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] web: adapt z-index and dimensions of properties field types #159686

Conversation

fw-bot
Copy link
Contributor

@fw-bot fw-bot commented Mar 28, 2024

In 1, dropdowns were updated and it impacted the properties field edition:

  • z-index of the popover opened for the dropdown of a property field type was lower than the element it was opened for, resulting in part of the popover being hidden.
  • img style (dimensions) was not applied as the dropdown list is now a popover (sibling instead of child), resulting in bigger images.

This commit fixes the issue by adding a class on the field type selection popover.

task-3834506

Forward-Port-Of: #159463

In [1], dropdowns were updated and it impacted the properties field edition:
- z-index of the popover opened for the dropdown of a property field type was
  lower than the element it was opened for, resulting in part of the popover
  being hidden.
- img style (dimensions) was not applied as the dropdown list is now a popover
  (sibling instead of child), resulting in bigger images.

This commit fixes the issue by adding a class on the field type selection
popover.

[1]: odoo@7b7a261

task-3834506

X-original-commit: f202f6f
@robodoo
Copy link
Contributor

robodoo commented Mar 28, 2024

@fw-bot
Copy link
Contributor Author

fw-bot commented Mar 28, 2024

@abd-msyukyu-odoo @awa-odoo this PR targets master and is the last of the forward-port chain.

To merge the full chain, use

@fw-bot r+

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@C3POdoo C3POdoo added the RD research & development, internal work label Mar 28, 2024
@robodoo robodoo added the forwardport This PR was created by @fw-bot label Mar 28, 2024
@awa-odoo
Copy link
Contributor

awa-odoo commented Apr 2, 2024

@fw-bot r+

robodoo pushed a commit that referenced this pull request Apr 2, 2024
In [1], dropdowns were updated and it impacted the properties field edition:
- z-index of the popover opened for the dropdown of a property field type was
  lower than the element it was opened for, resulting in part of the popover
  being hidden.
- img style (dimensions) was not applied as the dropdown list is now a popover
  (sibling instead of child), resulting in bigger images.

This commit fixes the issue by adding a class on the field type selection
popover.

[1]: 7b7a261

task-3834506

closes #159686

X-original-commit: f202f6f
Related: odoo/enterprise#59649
Signed-off-by: Warnon Aurélien (awa) <awa@odoo.com>
@robodoo robodoo closed this Apr 2, 2024
@robodoo robodoo added the 17.3 label Apr 2, 2024
@fw-bot fw-bot deleted the master-saas-17.2-knowledge-fix-popover-zindex-abd-ajmk-fw branch April 16, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
17.3 forwardport This PR was created by @fw-bot RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants