[IMP] mail: clean up starredPersonas #159466
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phenix-factory
force-pushed
the
master-refactor-starred-message-did
branch
from
e9ff605
to
b2968cc
Compare
phenix-factory
force-pushed
the
master-refactor-starred-message-did
branch
3 times, most recently
from
a4174fc
to
bd5af49
Compare
phenix-factory
force-pushed
the
master-refactor-starred-message-did
branch
7 times, most recently
from
2237175
to
ee21396
Compare
phenix-factory
force-pushed
the
master-refactor-starred-message-did
branch
9 times, most recently
from
cd53a36
to
5929ed5
Compare
phenix-factory
force-pushed
the
master-refactor-starred-message-did
branch
4 times, most recently
from
27e1b3c
to
118e4ea
Compare
phenix-factory
force-pushed
the
master-refactor-starred-message-did
branch
11 times, most recently
from
0079f1d
to
c46804f
Compare
Before this PR, `_message_format` function always included data that were only relevant to the logged user. It also `leak partner_ids`. This PR condition the `needaction_partner_ids`, `history_partner_ids`, `starredPersonas` and `trackingValues` values to a new param. This allows us to control when those data should be sent to the user.
phenix-factory
force-pushed
the
master-refactor-starred-message-did
branch
4 times, most recently
from
6a3fd01
to
20c14ef
Compare
phenix-factory
changed the title
phenix-factory
force-pushed
the
master-refactor-starred-message-did
branch
from
20c14ef
to
0f7d74b
Compare
Before this PR, `_message_format` sent all of the users that starred a message to the JS code. Since odoo#162065, this behavior is not necessary anymore and a boolean can be used.
phenix-factory
force-pushed
the
master-refactor-starred-message-did
branch
from
0f7d74b
to
c446c71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR,
_message_formatsent all of the users that starred a message tothe JS code.
Since #162065, this behavior is not necessary
anymore and a boolean can be used.