[IMP] mail: avoid broadcasting partner lists and tracking values #162065
+88
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phenix-factory
force-pushed
the
master-remove-need-action-from-message-format-did
branch
12 times, most recently
from
afb71f5
to
9b4818c
Compare
|
No task, no explanation ? Don't mark as ready when we cannot review. |
phenix-factory
force-pushed
the
master-remove-need-action-from-message-format-did
branch
from
9b4818c
to
b9e7b61
Compare
phenix-factory
changed the title
|
@tde-banana-odoo I update the commit and the PR description to provide some context. |
phenix-factory
force-pushed
the
master-remove-need-action-from-message-format-did
branch
5 times, most recently
from
bc5f485
to
41db430
Compare
seb-odoo
reviewed
Apr 18, 2024
seb-odoo
reviewed
Apr 18, 2024
phenix-factory
force-pushed
the
master-remove-need-action-from-message-format-did
branch
from
41db430
to
893f6a3
Compare
phenix-factory
force-pushed
the
master-remove-need-action-from-message-format-did
branch
6 times, most recently
from
a714fcc
to
81cad5d
Compare
alexkuhn
reviewed
Apr 23, 2024
There was a problem hiding this comment.
PR looks more code cleaning than anything.
I don't mind it, but as it is it introduces some disparity between _message_format_personalize and _message_format(for_current_user).
It'd be nice to match the wording, and also they have similar concerns so would be also nice to improve locality by using similar LOCs. For example, _message_format_personalize code could be moved into _message_format and there's a parameter to personalise for given partners.
phenix-factory
added a commit
to odoo-dev/odoo
that referenced
this pull request
Apr 23, 2024
Before this PR, _message_format send all of the user that starred a message to the JS code. Since odoo#162065, this behaviour is not necessary anymore and a boolean can be used.
phenix-factory
added a commit
to odoo-dev/odoo
that referenced
this pull request
Apr 23, 2024
Before this PR, _message_format sent all of the users that starred a message to the JS code. Since odoo#162065, this behavior is not necessary anymore and a boolean can be used.
phenix-factory
added a commit
to odoo-dev/odoo
that referenced
this pull request
Apr 23, 2024
Before this PR, _message_format send all of the user that had a "need action" on a message to the JS code. Since odoo#162065, this behaviour is not necessary anymore and a boolean can be used.
phenix-factory
added a commit
to odoo-dev/odoo
that referenced
this pull request
Apr 23, 2024
Before this PR, `_message_format` sends all of the users that had a "need action" on a message to the JS code. Since odoo#162065, this behavior is not necessary anymore and a boolean can be used.
phenix-factory
added a commit
to odoo-dev/odoo
that referenced
this pull request
Apr 23, 2024
Before this PR, `_message_format` sent all of the users that starred a message to the JS code. Since odoo#162065, this behavior is not necessary anymore and a boolean can be used.
phenix-factory
force-pushed
the
master-remove-need-action-from-message-format-did
branch
6 times, most recently
from
432d86c
to
7949d3e
Compare
Before this PR, `_message_format` function always included data that were only relevant to the logged user. It also `leak partner_ids`. This PR condition the `needaction_partner_ids`, `history_partner_ids`, `starredPersonas` and `trackingValues` values to a new param. This allows us to control when those data should be sent to the user. PR enterprise: odoo/enterprise#61353
phenix-factory
force-pushed
the
master-remove-need-action-from-message-format-did
branch
from
7949d3e
to
44f86cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR,
_message_formatfunction always included data that were onlyrelevant to the logged user. It also
leak partner_ids.This PR condition the
needaction_partner_ids,history_partner_ids,starredPersonasandtrackingValuesvalues to a new param.This allows us to control when those data should be sent to the user.
PR enterprise: https://github.com/odoo/enterprise/pull/61353