[FW][FIX] website_slides: load animations after slide loaded #159514
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: When using the Fullscreen mode of slides for articles we do run first the website animations before loading the slide, which will make the content to stay invisible since we will never actually perform the animation. Steps to reproduce: 1. Create a new course with an article content. 2. Add any block (text, image). 3. Add an animation to this piece of block. 4. Go to Fullscreen mode. Solution: We manually instantiate and attach the WebsiteAnimate widget to the wpContainer element to ensure animations are properly initialized and applied after the slide has loaded, after that we get rid of this instance after every new slide that load so we avoid having multiple instances. opw-3757919 X-original-commit: 593ca1f
|
@Ephoniz @awa-odoo this PR targets master and is the last of the forward-port chain containing:
To merge the full chain, use
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
@fw-bot r+ |
robodoo
pushed a commit
that referenced
this pull request
Mar 29, 2024
Issue: When using the Fullscreen mode of slides for articles we do run first the website animations before loading the slide, which will make the content to stay invisible since we will never actually perform the animation. Steps to reproduce: 1. Create a new course with an article content. 2. Add any block (text, image). 3. Add an animation to this piece of block. 4. Go to Fullscreen mode. Solution: We manually instantiate and attach the WebsiteAnimate widget to the wpContainer element to ensure animations are properly initialized and applied after the slide has loaded, after that we get rid of this instance after every new slide that load so we avoid having multiple instances. opw-3757919 closes #159514 X-original-commit: 593ca1f Signed-off-by: Warnon Aurélien (awa) <awa@odoo.com> Signed-off-by: Maruan Aguerdouh Mohtar (magm) <magm@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: When using the Fullscreen mode of slides for articles we do run first the website animations before loading the slide, which will make the content to stay invisible since we will never actually perform the animation.
Steps to reproduce:
Solution:
We could manually instantiate and attach the WebsiteAnimate widget to the #wrapwrap element to ensure animations are properly initialized and applied after the slide has loaded.
opw-3757919
Forward-Port-Of: #159032
Forward-Port-Of: #155780