Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] website_sale: non deterministic test failures #159747

Conversation

fw-bot
Copy link
Contributor

@fw-bot fw-bot commented Mar 28, 2024

Wild try to avoid failures on runbot builds (not reproducible locally).

  • simplify and split tour steps
  • correctly specify check steps as isCheck: true
  • make sure python setup is deterministic
    • batch template creation to avoid creation of dummy archived variant
    • target values for the variant to archive instead of its number in the list of variants

runbot build error 25046


I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: #159398
Forward-Port-Of: #159270

Wild try to avoid failures on runbot builds (not reproducible locally).

* simplify and split tour steps
* correctly specify check steps as isCheck: true
* make sure python setup is deterministic
  * batch template creation to avoid creation of dummy archived variant
  * target values for the variant to archive instead of its number in the
  list of variants

runbot build error 25046

X-original-commit: ff83cce
@robodoo
Copy link
Contributor

robodoo commented Mar 28, 2024

@fw-bot
Copy link
Contributor Author

fw-bot commented Mar 28, 2024

@Feyensv this PR targets master and is the last of the forward-port chain.

To merge the full chain, use

@fw-bot r+

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@robodoo robodoo added the forwardport This PR was created by @fw-bot label Mar 28, 2024
@Feyensv
Copy link
Contributor

Feyensv commented Mar 28, 2024

@fw-bot r+

@C3POdoo C3POdoo added the RD research & development, internal work label Mar 28, 2024
robodoo pushed a commit that referenced this pull request Apr 2, 2024
Wild try to avoid failures on runbot builds (not reproducible locally).

* simplify and split tour steps
* correctly specify check steps as isCheck: true
* make sure python setup is deterministic
  * batch template creation to avoid creation of dummy archived variant
  * target values for the variant to archive instead of its number in the
  list of variants

runbot build error 25046

closes #159747

X-original-commit: ff83cce
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
@robodoo robodoo added the 17.3 label Apr 2, 2024
@robodoo robodoo closed this Apr 2, 2024
@fw-bot fw-bot deleted the master-saas-16.4-wsale-runbot-error-vfe-pzvF-fw branch April 16, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
17.3 forwardport This PR was created by @fw-bot RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants