[10.0] [IMP] purchase_requisition: prepare method for order lines creation #16080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a prepare method easy to override in Purchase Requisition Line to create the dictionary of values for order line creation
|
OPW 740248 |
|
Hello, We generally do merge this kind of refactorings in master, not in a stable release. Regards (cc @mart-e ) |
|
@ThomasBinsfeld Thanks for the feedback. Your improvement has been merged in master at 2742722 |
tivisse
pushed a commit
that referenced
this pull request
May 30, 2017
Closes #16080 Add a prepare method easy to override in Purchase Requisition Line to create the dictionary of values for order line creation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses:
Add a prepare method easy to override in Purchase Requisition Line to create the dictionary of values for order line creation.
Current behavior before PR:
The dictionary of purchase order lines values is built in the
_onchange_requisition_idof Purchase Order. Custom modules cannot easily modify this dictionary.Desired behavior after PR is merged:
The dictionary is built in an easy to override preparation method in Purchase Requisition Line, with
api.multidecorator to access thepurchase.requisition.lineobject on which we create the purchase order line.I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr