Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] calendar: allow internal users to download invitation.ics #162260

Closed

Conversation

fw-bot
Copy link
Contributor

@fw-bot fw-bot commented Apr 17, 2024

Access rights on ir.attachment depend on the record it is linked to.

steps to reproduce:

  • log as admin
  • create a calendar event and invite marc demo
  • log as marc demo
  • check discuss notifications and try to download "invite.ics"

before this commit:

  • file can not be downloaded from the webclient (access error appear in logs)

after this commit:

  • file can be downloaded from the webclient

opw-3754798


I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: #160811

@robodoo
Copy link
Contributor

robodoo commented Apr 17, 2024

Pull request status dashboard.

@fw-bot
Copy link
Contributor Author

fw-bot commented Apr 17, 2024

@nda-odoo @arj-odoo cherrypicking of pull request #160811 failed.

stdout:

Auto-merging addons/calendar/models/calendar_attendee.py
Auto-merging addons/calendar/tests/test_calendar.py
CONFLICT (content): Merge conflict in addons/calendar/tests/test_calendar.py

stderr:

17:16:14.861646 git.c:463               trace: built-in: git cherry-pick f87b647ce5243c776dc1de3196bc7b94f7d8410b
error: could not apply f87b647ce524... [FIX] calendar: allow internal users to download invitation.ics
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
----------
status:

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

⚠️ after resolving this conflict, you will need to merge it via @robodoo.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@robodoo robodoo added forwardport This PR was created by @fw-bot conflict There was an error while creating this forward-port PR labels Apr 17, 2024
@nda-odoo nda-odoo force-pushed the 16.0-15.0-3754798-calendar-ics-nda-fuWc-fw branch from c37cdb7 to 0a97272 Compare April 17, 2024 15:46
@C3POdoo C3POdoo requested a review from a team April 17, 2024 15:48
@C3POdoo C3POdoo added the OE the report is linked to a support ticket (opw-...) label Apr 17, 2024
Access rights on ir.attachment depend on the record it is linked to.

steps to reproduce:
- log as admin
- create a calendar event and invite marc demo
- log as marc demo
- check discuss notifications and try to download "invite.ics"

before this commit:
- file can not be downloaded from the webclient (access error appear in logs)

after this commit:
- file can be downloaded from the webclient

opw-3754798

X-original-commit: 5b930b7
@nda-odoo nda-odoo force-pushed the 16.0-15.0-3754798-calendar-ics-nda-fuWc-fw branch from 0a97272 to 2eac688 Compare April 18, 2024 14:31
@nda-odoo
Copy link
Contributor

@robodoo r+

robodoo pushed a commit that referenced this pull request Apr 18, 2024
Access rights on ir.attachment depend on the record it is linked to.

steps to reproduce:
- log as admin
- create a calendar event and invite marc demo
- log as marc demo
- check discuss notifications and try to download "invite.ics"

before this commit:
- file can not be downloaded from the webclient (access error appear in logs)

after this commit:
- file can be downloaded from the webclient

opw-3754798

closes #162260

X-original-commit: 5b930b7
Signed-off-by: Arnaud Joset (arj) <arj@odoo.com>
Signed-off-by: Nicolas Danhier (nda) <nda@odoo.com>
@robodoo robodoo closed this Apr 18, 2024
@fw-bot fw-bot deleted the 16.0-15.0-3754798-calendar-ics-nda-fuWc-fw branch May 2, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conflict There was an error while creating this forward-port PR forwardport This PR was created by @fw-bot OE the report is linked to a support ticket (opw-...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants