Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] calendar: allow internal users to download invitation.ics #162502

Conversation

fw-bot
Copy link
Contributor

@fw-bot fw-bot commented Apr 18, 2024

Access rights on ir.attachment depend on the record it is linked to.

steps to reproduce:

  • log as admin
  • create a calendar event and invite marc demo
  • log as marc demo
  • check discuss notifications and try to download "invite.ics"

before this commit:

  • file can not be downloaded from the webclient (access error appear in logs)

after this commit:

  • file can be downloaded from the webclient

opw-3754798


I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: #162260
Forward-Port-Of: #160811

@robodoo
Copy link
Contributor

robodoo commented Apr 18, 2024

@fw-bot
Copy link
Contributor Author

fw-bot commented Apr 18, 2024

@nda-odoo @arj-odoo cherrypicking of pull request #160811 failed.

stdout:

Auto-merging addons/calendar/models/calendar_attendee.py
CONFLICT (content): Merge conflict in addons/calendar/models/calendar_attendee.py
Auto-merging addons/calendar/tests/test_calendar.py

stderr:

19:35:52.730383 git.c:463               trace: built-in: git cherry-pick 2eac68855c0df22ffb23e0a86a67dc9bbfb45728
error: could not apply 2eac68855c0d... [FIX] calendar: allow internal users to download invitation.ics
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
----------
status:

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

⚠️ after resolving this conflict, you will need to merge it via @robodoo.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@robodoo robodoo added forwardport This PR was created by @fw-bot conflict There was an error while creating this forward-port PR labels Apr 18, 2024
@C3POdoo C3POdoo added the OE the report is linked to a support ticket (opw-...) label Apr 18, 2024
Access rights on ir.attachment depend on the record it is linked to.

steps to reproduce:
- log as admin
- create a calendar event and invite marc demo
- log as marc demo
- check discuss notifications and try to download "invite.ics"

before this commit:
- file can not be downloaded from the webclient (access error appear in logs)

after this commit:
- file can be downloaded from the webclient

opw-3754798

X-original-commit: 5ea164b
@nda-odoo nda-odoo force-pushed the saas-16.3-15.0-3754798-calendar-ics-nda-nqWH-fw branch from 35d5fce to 54ebc47 Compare April 18, 2024 20:15
@C3POdoo C3POdoo requested a review from a team April 18, 2024 20:17
@nda-odoo
Copy link
Contributor

@robodoo r+

robodoo pushed a commit that referenced this pull request Apr 19, 2024
Access rights on ir.attachment depend on the record it is linked to.

steps to reproduce:
- log as admin
- create a calendar event and invite marc demo
- log as marc demo
- check discuss notifications and try to download "invite.ics"

before this commit:
- file can not be downloaded from the webclient (access error appear in logs)

after this commit:
- file can be downloaded from the webclient

opw-3754798

closes #162502

X-original-commit: 5ea164b
Signed-off-by: Arnaud Joset (arj) <arj@odoo.com>
Signed-off-by: Nicolas Danhier (nda) <nda@odoo.com>
@robodoo robodoo closed this Apr 19, 2024
@fw-bot fw-bot deleted the saas-16.3-15.0-3754798-calendar-ics-nda-nqWH-fw branch May 3, 2024 16:47
nd-dew added a commit to odoo-dev/odoo that referenced this pull request May 29, 2024
…n public user is booking

**new reproduction steps**
- Install appointment,website
- Book an appointment as Mark Demo with Mitchell Admin -> Emails with .ics are sent
- Book an appointment as Public user -> BUG: Emails are sent without .ics

Note this commit is overridicng changes from NDA PR
odoo#162502
However flow decriibed there works just fine

ble

opw-3685871
nd-dew added a commit to odoo-dev/odoo that referenced this pull request May 31, 2024
…n public user is booking

**new reproduction steps**
- Install appointment,website
- Book an appointment as Mark Demo with Mitchell Admin -> Emails with .ics are sent
- Book an appointment as Public user -> BUG: Emails are sent without .ics

Note this commit is overridicng changes from NDA PR
odoo#162502
However flow decriibed there works just fine

ble

opw-3685871
nd-dew added a commit to odoo-dev/odoo that referenced this pull request May 31, 2024
…n public user is booking

**new reproduction steps**
- Install appointment,website
- Book an appointment as Mark Demo with Mitchell Admin -> Emails with .ics are sent
- Book an appointment as Public user -> BUG: Emails are sent without .ics

Note this commit is overridicng changes from NDA PR
odoo#162502
However flow decriibed there works just fine

ble

opw-3685871
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conflict There was an error while creating this forward-port PR forwardport This PR was created by @fw-bot OE the report is linked to a support ticket (opw-...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants