Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] point_of_sale: correctly reconcile reversed payments #162994

Conversation

fw-bot
Copy link
Contributor

@fw-bot fw-bot commented Apr 23, 2024

Current behavior:
When an order is invoided after the session has been closed, a reversed payment is created. This payment is not reconciled correctly with the invoice. This is creating an aged receivable for the partner.

Steps to reproduce:

  • Change the bank payment method to "Identify customer"
  • Create an order in the PoS and pay with bank and specify a partner
  • Close the session
  • Open the session again, and create an invoice for the order
  • Go to the accounting module and look for the aged receivable report you should see some entries under the partner you selected.
  • You can also go to the partner form and see that he has some due invoices.

opw-3678298

I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: #162857
Forward-Port-Of: #156527

@robodoo
Copy link
Contributor

robodoo commented Apr 23, 2024

@fw-bot
Copy link
Contributor Author

fw-bot commented Apr 23, 2024

@robinengels @caburj cherrypicking of pull request #156527 failed.

stdout:

Auto-merging addons/point_of_sale/models/pos_order.py
Auto-merging addons/point_of_sale/tests/test_point_of_sale_flow.py
CONFLICT (content): Merge conflict in addons/point_of_sale/tests/test_point_of_sale_flow.py

stderr:

14:57:11.880022 git.c:463               trace: built-in: git cherry-pick ae581230bffc376ecfbc7d49b9d991a851a054fb
error: could not apply ae581230bffc... [FIX] point_of_sale: correctly reconcile reversed payments
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
----------
status:

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

⚠️ after resolving this conflict, you will need to merge it via @robodoo.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@C3POdoo C3POdoo added the OE the report is linked to a support ticket (opw-...) label Apr 23, 2024
@robodoo robodoo added forwardport This PR was created by @fw-bot conflict There was an error while creating this forward-port PR labels Apr 23, 2024
@robinengels robinengels force-pushed the saas-17.2-16.0-opw-3678298-age_negative-roen-CFMY-fw branch from c1490d1 to 8378a26 Compare April 24, 2024 12:18
Current behavior:
When an order is invoided after the session has been closed, a reversed
payment is created. This payment is not reconciled correctly with the
invoice. This is creating an aged receivable for the partner.

Steps to reproduce:
- Change the bank payment method to "Identify customer"
- Create an order in the PoS and pay with bank and specify a partner
- Close the session
- Open the session again, and create an invoice for the order
- Go to the accounting module and look for the aged receivable report
  you should see some entries under the partner you selected.
- You can also go to the partner form and see that he has some due
  invoices.

opw-3678298

correct partner

X-original-commit: cc7649d
@robinengels robinengels force-pushed the saas-17.2-16.0-opw-3678298-age_negative-roen-CFMY-fw branch from 8378a26 to 4f22d68 Compare April 24, 2024 12:19
@robinengels
Copy link
Contributor

@robodoo r+

@C3POdoo C3POdoo requested review from a team and vlst-odoo and removed request for a team April 24, 2024 12:22
@robodoo
Copy link
Contributor

robodoo commented Apr 24, 2024

@robinengels @caburj linked pull request(s) odoo/enterprise#61321 not ready. Linked PRs are not staged until all of them are ready.

robodoo pushed a commit that referenced this pull request Apr 24, 2024
Current behavior:
When an order is invoided after the session has been closed, a reversed
payment is created. This payment is not reconciled correctly with the
invoice. This is creating an aged receivable for the partner.

Steps to reproduce:
- Change the bank payment method to "Identify customer"
- Create an order in the PoS and pay with bank and specify a partner
- Close the session
- Open the session again, and create an invoice for the order
- Go to the accounting module and look for the aged receivable report
  you should see some entries under the partner you selected.
- You can also go to the partner form and see that he has some due
  invoices.

opw-3678298

correct partner

closes #162994

X-original-commit: cc7649d
Related: odoo/enterprise#61321
Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>
Signed-off-by: Robin Engels (roen) <roen@odoo.com>
@robodoo robodoo closed this Apr 24, 2024
@fw-bot fw-bot deleted the saas-17.2-16.0-opw-3678298-age_negative-roen-CFMY-fw branch May 8, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conflict There was an error while creating this forward-port PR forwardport This PR was created by @fw-bot OE the report is linked to a support ticket (opw-...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants