Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] point_of_sale: correctly reconcile reversed payments #156527

Closed

Conversation

robinengels
Copy link
Contributor

@robinengels robinengels commented Mar 5, 2024

Current behavior:
When an order is invoided after the session has been closed, a reversed payment is created. This payment is not reconciled correctly with the invoice. This is creating an aged receivable for the partner.

Steps to reproduce:

  • Change the bank payment method to "Identify customer"
  • Create an order in the PoS and pay with bank and specify a partner
  • Close the session
  • Open the session again, and create an invoice for the order
  • Go to the accounting module and look for the aged receivable report you should see some entries under the partner you selected.
  • You can also go to the partner form and see that he has some due invoices.

opw-3678298

I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo
Copy link
Contributor

robodoo commented Mar 5, 2024

@robinengels robinengels force-pushed the 16.0-opw-3678298-age_negative-roen branch from d831c8e to 92ac5d6 Compare March 5, 2024 14:34
@C3POdoo C3POdoo requested review from a team and caburj and removed request for a team March 5, 2024 14:37
@C3POdoo C3POdoo added the OE the report is linked to a support ticket (opw-...) label Mar 5, 2024
@robinengels robinengels force-pushed the 16.0-opw-3678298-age_negative-roen branch 4 times, most recently from 8a3cfb4 to 6783b5b Compare March 7, 2024 10:19
@robinengels robinengels force-pushed the 16.0-opw-3678298-age_negative-roen branch 2 times, most recently from d2ce51c to b38ee32 Compare March 20, 2024 16:17
@C3POdoo C3POdoo requested a review from a team March 20, 2024 16:22
@robinengels robinengels removed the request for review from a team March 20, 2024 16:29
@robinengels robinengels marked this pull request as draft March 21, 2024 10:43
@robinengels robinengels force-pushed the 16.0-opw-3678298-age_negative-roen branch 4 times, most recently from 65a20a7 to b5bb6c9 Compare March 25, 2024 14:10
@robinengels robinengels marked this pull request as ready for review March 26, 2024 10:06
@C3POdoo C3POdoo requested a review from a team March 26, 2024 10:08
@robinengels robinengels force-pushed the 16.0-opw-3678298-age_negative-roen branch from b5bb6c9 to 5a3e1a6 Compare March 26, 2024 11:56
@robinengels robinengels force-pushed the 16.0-opw-3678298-age_negative-roen branch from 5a3e1a6 to 2e5cb81 Compare April 8, 2024 09:33
@robinengels
Copy link
Contributor Author

@caburj I moved the test here because that module depends on account_followup so the field is always available there https://github.com/odoo/enterprise/pull/60248

@robinengels robinengels force-pushed the 16.0-opw-3678298-age_negative-roen branch from 2e5cb81 to fe04096 Compare April 8, 2024 10:50
@robinengels robinengels force-pushed the 16.0-opw-3678298-age_negative-roen branch 3 times, most recently from 842a8c1 to 1b0afa5 Compare April 17, 2024 12:46
Current behavior:
When an order is invoided after the session has been closed, a reversed
payment is created. This payment is not reconciled correctly with the
invoice. This is creating an aged receivable for the partner.

Steps to reproduce:
- Change the bank payment method to "Identify customer"
- Create an order in the PoS and pay with bank and specify a partner
- Close the session
- Open the session again, and create an invoice for the order
- Go to the accounting module and look for the aged receivable report
  you should see some entries under the partner you selected.
- You can also go to the partner form and see that he has some due
  invoices.

opw-3678298

correct partner
@robinengels robinengels force-pushed the 16.0-opw-3678298-age_negative-roen branch from 135176c to e62186a Compare April 18, 2024 10:53
@caburj
Copy link
Contributor

caburj commented Apr 19, 2024

robodoo r+

robodoo pushed a commit that referenced this pull request Apr 19, 2024
Current behavior:
When an order is invoided after the session has been closed, a reversed
payment is created. This payment is not reconciled correctly with the
invoice. This is creating an aged receivable for the partner.

Steps to reproduce:
- Change the bank payment method to "Identify customer"
- Create an order in the PoS and pay with bank and specify a partner
- Close the session
- Open the session again, and create an invoice for the order
- Go to the accounting module and look for the aged receivable report
  you should see some entries under the partner you selected.
- You can also go to the partner form and see that he has some due
  invoices.

opw-3678298

correct partner

closes #156527

Related: odoo/enterprise#60248
Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>
@robodoo robodoo closed this Apr 19, 2024
@fw-bot
Copy link
Contributor

fw-bot commented Apr 24, 2024

@fw-bot
Copy link
Contributor

fw-bot commented Apr 25, 2024

1 similar comment
@fw-bot
Copy link
Contributor

fw-bot commented Apr 26, 2024

@fw-bot
Copy link
Contributor

fw-bot commented Apr 27, 2024

@robinengels @caburj this pull request has forward-port PRs awaiting action (not merged or closed):

2 similar comments
@fw-bot
Copy link
Contributor

fw-bot commented Apr 28, 2024

@robinengels @caburj this pull request has forward-port PRs awaiting action (not merged or closed):

@fw-bot
Copy link
Contributor

fw-bot commented Apr 29, 2024

@robinengels @caburj this pull request has forward-port PRs awaiting action (not merged or closed):

MohammedBasioni pushed a commit to odoo-dev/odoo that referenced this pull request Apr 29, 2024
Current behavior:
When an order is invoided after the session has been closed, a reversed
payment is created. This payment is not reconciled correctly with the
invoice. This is creating an aged receivable for the partner.

Steps to reproduce:
- Change the bank payment method to "Identify customer"
- Create an order in the PoS and pay with bank and specify a partner
- Close the session
- Open the session again, and create an invoice for the order
- Go to the accounting module and look for the aged receivable report
  you should see some entries under the partner you selected.
- You can also go to the partner form and see that he has some due
  invoices.

opw-3678298

correct partner

closes odoo#156527

Related: odoo/enterprise#60248
Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OE the report is linked to a support ticket (opw-...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants