[FIX] mail: allow bypassing message attachments check #164874
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some modules may use attachments from mail messages directly. We want to allow to bypass the check on message attachments if there is a need for it. It will immediately be used for the enterprise documents app. Also return True instead of None in the override of `check` to match the behavior of the parent. Also reword the error message to convey writing is also forbidden. task-3519815
|
|
reth-odoo
changed the title
Administrators are technically allowed to delete attachments from any message. However the UI does not reflect that since [1] 1: 4c4e63f task-3519815
reth-odoo
force-pushed
the
15.0-documents-fix-mail-attachment-access-rights-reth
branch
from
44cdbeb
to
671a907
Compare
|
Closed in favor of #164894 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases it may be necessary to bypass the check for attachments on other users messages
if the attachment from the message is used for another purpose without being copied.
We add a method to filter out the attachments for that check.
Additional changes:
Trueinstead ofNonewhen it succeeds, to match its parentissue introduced in odoo/odoo#4c4e63f01aefa01c2377f15f2020485cb0f7e4da
task-3519815