[FIX] mail: allow bypassing message attachments check #164894
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
reth-odoo
force-pushed
the
15.0-documents-fix-mail-attachment-write-access-reth
branch
from
32223b8
to
3d0da46
Compare
awa-odoo
reviewed
May 8, 2024
There was a problem hiding this comment.
Hello @reth-odoo
A couple light comments but globally LGTM for the community part.
Thanks for your reactivity on this & cheers!
reth-odoo
force-pushed
the
15.0-documents-fix-mail-attachment-write-access-reth
branch
2 times, most recently
from
ff7202a
to
28a768c
Compare
reth-odoo
force-pushed
the
15.0-documents-fix-mail-attachment-write-access-reth
branch
from
28a768c
to
93ef9d8
Compare
Some modules may use attachments from mail messages directly. In that case it may be desirable to at least be able to write over the name and other non-critical information even if the attachment is linked to a document. The restrictions on writing on message attachments is reduced to only apply to data fields, as those are the only ones that we really don't want people to change. Also return True instead of None in the override of `check` to match the behavior of the parent. Also reword the error message to convey writing is also forbidden. Complementary to 4c4e63f task-3519815
reth-odoo
force-pushed
the
15.0-documents-fix-mail-attachment-write-access-reth
branch
from
93ef9d8
to
ab6bac3
Compare
Administrators are technically allowed to delete attachments from any message. However the UI does not reflect that since [1] 1: 4c4e63f task-3519815
reth-odoo
force-pushed
the
15.0-documents-fix-mail-attachment-write-access-reth
branch
from
ab6bac3
to
8537b4e
Compare
|
@robodoo r+ rebase-ff |
|
Merge method set to rebase and fast-forward. |
robodoo
pushed a commit
that referenced
this pull request
May 8, 2024
Some modules may use attachments from mail messages directly. In that case it may be desirable to at least be able to write over the name and other non-critical information even if the attachment is linked to a document. The restrictions on writing on message attachments is reduced to only apply to data fields, as those are the only ones that we really don't want people to change. Also return True instead of None in the override of `check` to match the behavior of the parent. Also reword the error message to convey writing is also forbidden. Complementary to 4c4e63f task-3519815 Part-of: #164894
robodoo
pushed a commit
that referenced
this pull request
May 8, 2024
Administrators are technically allowed to delete attachments from any message. However the UI does not reflect that since [1] 1: 4c4e63f task-3519815 closes #164894 Related: odoo/enterprise#62174 Signed-off-by: Warnon Aurélien (awa) <awa@odoo.com>
This was referenced May 8, 2024
|
@reth-odoo @awa-odoo this pull request has forward-port PRs awaiting action (not merged or closed): |
|
@reth-odoo @awa-odoo this pull request has forward-port PRs awaiting action (not merged or closed): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only care about data fields when it comes to restricting access to message attachments.
As some modules may use these attachments directly, it may be desirable for them to use
the attachment name or similar metadata fields.
"write" is only restricted if writing on a data field, as it's effectively the same as unlinking
for our purposes. Other fields have the same access rights as prior to [1]
Additional changes:
1: 4c4e63f
task-3519815