[account_check_printing] : assign and display check number when payment is confirmed #16560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsh-odoo
force-pushed
the
master-account_check_printing-imp-hsh
branch
from
e5a9476
to
574de87
Compare
hsh-odoo
force-pushed
the
master-account_check_printing-imp-hsh
branch
2 times, most recently
from
5790328
to
b9be7b2
Compare
hsh-odoo
force-pushed
the
master-account_check_printing-imp-hsh
branch
from
b9be7b2
to
6e6a272
Compare
hsh-odoo
force-pushed
the
master-account_check_printing-imp-hsh
branch
from
6e6a272
to
f164329
Compare
smetl
requested changes
Aug 3, 2017
| payment_method_check = self.env.ref('account_check_printing.account_payment_method_check') | ||
| for payment in self.filtered(lambda r: r.payment_method_id == payment_method_check and r.check_manual_sequencing): | ||
| sequence = payment.journal_id.check_sequence_id | ||
| payment.check_number = sequence.next_by_id() |
There was a problem hiding this comment.
You should return the result of super
res = super(AccountPayment, self).post()
...
return res
hsh-odoo
force-pushed
the
master-account_check_printing-imp-hsh
branch
3 times, most recently
from
cd4314e
to
9a8253c
Compare
hsh-odoo
force-pushed
the
master-account_check_printing-imp-hsh
branch
from
9a8253c
to
7b4520a
Compare
hsh-odoo
force-pushed
the
master-account_check_printing-imp-hsh
branch
from
4ed3ad9
to
36e82cc
Compare
|
LGTM |
hsh-odoo
force-pushed
the
master-account_check_printing-imp-hsh
branch
6 times, most recently
from
6124604
to
59397b1
Compare
…irmation Purpose ======= Avoid issues in checks numbering. Specification ============= When the manual numbering of the checks is ticked on the bank journal, assign and display number to the check only when the payment is confirmed, not when the check is still in draft.
tivisse
force-pushed
the
master-account_check_printing-imp-hsh
branch
from
59397b1
to
824b48f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr