Update views.rst to make color an required attribute #16671
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting a color is required because the web_calendar.js:799 is using "if (color_field.type == "selection")" so its throwing this error when color is not defined: Uncaught TypeError: Cannot read property 'type' of undefined
|
Hello, Instead of making it required in the doc, shouldn't we make the calendar work, even without the attribute? |
|
Hi, @mart-e look https://github.com/odoo/odoo/blob/10.0/addons/web_calendar/static/src/js/web_calendar.js#L791 When the flag |
Commit 5fddac7 fixes this error, so color no longer has to be a required field.
|
I did not test but the fix looks good 馃憤 |
|
Hi, Merged: 20facf5 Thank you for your contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses:
Making the color an required property because a JavaScript file is using it in a "if"-statement.
web_calendar.js:799if (color_field.type == "selection")Current behavior before PR:
Throwing the following error:
Uncaught TypeError: Cannot read property 'type' of undefined in web_calendar.js:799Desired behavior after PR is merged:
Odoo users will know how to avoid this error 馃憤
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr