[FIX] account: include user company in currency mapping #171605
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
diagnoza
reviewed
Jul 2, 2024
| @@ -56,6 +56,8 @@ def _get_query_currency_table(self, company_ids, conversion_date): | |||
| if companies == user_company: | |||
| currency_rates = {user_company.currency_id.id: 1.0} | |||
| else: | |||
| if user_company not in companies: | |||
| companies = companies | user_company | |||
There was a problem hiding this comment.
Suggested change
| companies = companies | user_company | |
| companies |= user_company |
C3POdoo
requested review from
a team and
william-andre
and removed request for
a team
When the current user is the system user, which happens during install and upgrades, the env company is possibly not included with the companies given to _get_query_currency_table, this can lead to a KeyError when fetching the rate for said company.
jjmaksoud
force-pushed
the
17.0-account-currency-companies-maji
branch
from
8a95269
to
a20e712
Compare
|
Not really, the instances when it was called during upgrade is when the record rules were updated and those are not company dependent. That's why it also happens during the installation of a module. To be more specific, the failure happens when the |
william-andre
approved these changes
Aug 9, 2024
This was referenced Aug 9, 2024
hsal-odoo
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Aug 12, 2024
When the current user is the system user, which happens during install and upgrades, the env company is possibly not included with the companies given to _get_query_currency_table, this can lead to a KeyError when fetching the rate for said company. closes odoo#171605 Signed-off-by: William André (wan) <wan@odoo.com>
Dasanchez1992
pushed a commit
to Nosolotec/odoo
that referenced
this pull request
Aug 22, 2024
When the current user is the system user, which happens during install and upgrades, the env company is possibly not included with the companies given to _get_query_currency_table, this can lead to a KeyError when fetching the rate for said company. closes odoo#171605 Signed-off-by: William André (wan) <wan@odoo.com>
riccardo-metrum
pushed a commit
to resultrum/odoo
that referenced
this pull request
Sep 30, 2024
When the current user is the system user, which happens during install and upgrades, the env company is possibly not included with the companies given to _get_query_currency_table, this can lead to a KeyError when fetching the rate for said company. closes odoo#171605 Signed-off-by: William André (wan) <wan@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses:
When the current user is the system user, which happens during install and upgrades, the env company is possibly not included with the companies given to
_get_query_currency_table, this can lead to a KeyError when fetching the rate for said company.Current behavior before PR:
Steps to reproduce:
_get_query_currency_table)Same behavior on upgrade if purchase is already installed and the company linked to the system user is deactivated and has a different currency than the active companies.
Desired behavior after PR is merged:
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr