[FIX] point_of_sale: _confirm_orders #17168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xmo-odoo
requested changes
May 23, 2017
| @@ -20,6 +20,8 @@ def _confirm_orders(self): | |||
| orders = session.order_ids.filtered(lambda order: order.state == 'paid') | |||
| journal_id = self.env['ir.config_parameter'].sudo().get_param( | |||
| 'pos.closing.journal_id_%s' % company_id, default=session.config_id.journal_id.id) | |||
| if not journal_id: | |||
| raise UserError(_("You have to set a Sale Journal for %s" % (session.config_id.name,))) | |||
There was a problem hiding this comment.
Incorrect, the format parameter should be outside the _() call.
There was a problem hiding this comment.
@xmo-odoo Thanks
simongoffin
force-pushed
the
10.0-point_of_sale-_confirm_orders-fix-sig
branch
2 times, most recently
from
c977fc4
to
396e3f0
Compare
xmo-odoo
approved these changes
May 24, 2017
simongoffin
force-pushed
the
10.0-point_of_sale-_confirm_orders-fix-sig
branch
from
396e3f0
to
6de446d
Compare
|
can a user still add a sale journal at this stage without losing POS Session data? |
simongoffin
force-pushed
the
10.0-point_of_sale-_confirm_orders-fix-sig
branch
from
6de446d
to
fc4cd52
Compare
To help users to know why they can't close their pos sessions when a Sales Journal is not set in the pos.config. opw:744758
simongoffin
force-pushed
the
10.0-point_of_sale-_confirm_orders-fix-sig
branch
from
fc4cd52
to
530546a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To help users to know why they can't close their pos sessions.
opw:744758