Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] mail: chat/channels search results are uppercase on mobile #174224

Closed
wants to merge 1 commit into from
Closed

[FIX] mail: chat/channels search results are uppercase on mobile #174224

wants to merge 1 commit into from

Conversation

Atovange
Copy link
Contributor

Before this commit, search results for chats and channels on mobile show up in uppercase.

This happens because of the class text-uppercase on a parent element.

This commit fixes the issue by removing said class on the parent element.

Before:
image

After:
image

@Atovange
[FIX] mail: chat/channels search results are uppercase on mobile
0c62ec2 
Before this commit, search results for chats and channels
on mobile show up in uppercase.

This happens because of the class `text-uppercase` on a parent element.
This commit fixes the issue by removing said class on the parent element.
@robodoo
Copy link
Contributor

robodoo commented Jul 23, 2024

Pull request status dashboard

@C3POdoo C3POdoo requested review from a team July 23, 2024 14:04
@C3POdoo C3POdoo added the RD research & development, internal work label Jul 23, 2024
alexkuhn
alexkuhn approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@alexkuhn alexkuhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The funny part is that text-uppercase was intended for the buttons. But honestly they don't necessarily look good with text-uppercase on their label. So ok for plain removal of this classname.

@robodoo r+

@robodoo robodoo closed this in 76bf4a2 Jul 23, 2024
This was referenced Jul 23, 2024
Closed
Closed
Closed
Closed
@fw-bot fw-bot deleted the 17.0-uppercase-search-results-gito branch August 6, 2024 17:46
Dasanchez1992 pushed a commit to Nosolotec/odoo that referenced this pull request Aug 22, 2024
@Atovange @Dasanchez1992
[FIX] mail: chat/channels search results are uppercase on mobile
0cf8174 
Before this commit, search results for chats and channels
on mobile show up in uppercase.

This happens because of the class `text-uppercase` on a parent element.
This commit fixes the issue by removing said class on the parent element.

closes odoo#174224

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexkuhn alexkuhn alexkuhn approved these changes

Assignees
No one assigned
Labels
RD research & development, internal work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Atovange @robodoo @alexkuhn @C3POdoo