[FIX] stock_account: fix traceback when try to install stock_account module #21107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nla-odoo
changed the title
|
Can't we use tools.config['demo'] instead ? |
…module. -'without_demo' param of tools.config always set value False when user make db from UI even if user have made db without demo data.
mba-odoo
force-pushed
the
master-stock_account-fix-traceback-issue-nla
branch
from
5999c18
to
1a4ae36
Compare
|
@tde-banana-odoo , No, we will not get tools.config['demo'] or tools.config['without_demo'] while creating Db with UI. Thanks |
|
LGTM then. |
|
Isn't it applicable to saas 11.1 ? I see original commit is before the freeze. |
|
@tde-banana-odoo , It's inside saas-11.1 https://github.com/odoo/odoo/blob/saas-11.1/addons/stock_account/__init__.py So can we fix in that? Thanks |
|
Hello, Yes you can make a PR targetting 11.1 Thanks ! |
|
@tde-banana-odoo , Here is the PR for 11.1 - #21899 |
|
Done in saas 11.1 at c268aa5 . Forward port will solve the issue in master. Thanks ! |
tde-banana-odoo
deleted the
master-stock_account-fix-traceback-issue-nla
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'without_demo' param of tools.config always set value False when user make DB from UI even if the user has made DB without demo data.
Issue: https://www.odoo.com/web#id=783157&view_type=form&model=project.issue&action=963&active_id=681&menu_id=4720
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr