-
Notifications
You must be signed in to change notification settings - Fork 24.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] l10n_uk: Created new account tags and assing into taxes #21493
Conversation
tag_pt7,PT7,taxes | ||
tag_st11,ST11,taxes | ||
tag_pt11,PT11,taxes | ||
tag_uk_01,Net VAT to be paid/reclaimed,taxes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should not define tags for the report lines aggregating other lines (and thus: not using any domain where to search for the tag). These tags will remain used, and hence are useless.
PT2,PT2,l10n_uk,purchase,Exempt purchases,percent,0,2201,2201,,"tag_uk_04,tag_uk_08",tax_group_0 | ||
PT8M,PT8M,l10n_uk,none,Standard rated purchases from EC,percent,17.5,2201,2201,,tag_uk_03,tax_group_0 | ||
PT8R,PT8R,l10n_uk,none,Reverse EC Purchase VAT,percent,-17.5,2201,2201,,tag_uk_05,tax_group_0 | ||
PT8,PT8,l10n_uk,purchase,Standard rated purchases from EC,group,,2201,2201,"PT8M,PT8R","tag_uk_09,tag_uk_03",tax_group_0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't only be tag_uk_09 ?
tag_st11,ST11,taxes | ||
tag_pt11,PT11,taxes | ||
tag_uk_01,Net VAT to be paid/reclaimed,taxes | ||
tag_uk_02,VAT on Sales and other outputs,taxes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should give better names to all your tags, as it was done in l10n_ch (here: https://github.com/odoo/odoo/blob/11.0/addons/l10n_ch/data/account_vat2011_data.xml ). Their ids should match the ones of the record lines they correspond to.
For example, for tag_uk_02, you should name it vat_tag_0101, as it relates to line financial_report_line_uk_0101. Please do the same for all other tags.
d2f5a98
to
7e3ee72
Compare
7e3ee72
to
718bf86
Compare
Created one tag per tax grid used in enterprise report Was task# 22697 Was PR odoo#21493 Related enterprise PR odoo/enterprise#1676
718bf86
to
1fdd8b7
Compare
@oco-odoo As the task was cancelled, can you confirm this to be cancelled too? |
@jco-odoo I suppose it must be canceled too; it depenrds on the content on the new task ;) |
@oco-odoo The new task was not adapted to this. And it would simplify the config. So, we will need to adapt it. |
Done at https://www.odoo.com/web#id=33297&view_type=form&model=project.task&menu_id= if I am not mistaken |
Task: https://www.odoo.com/web?debug=#id=22697&view_type=form&model=project.task&action=327&menu_id=4720
PAD: https://pad.odoo.com/p/r.f47955309f3674964eaf519b6ceaf45e