Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] l10n_uk: Created new account tags and assing into taxes #21493

Closed

Conversation

@C3POdoo C3POdoo added the RD research & development, internal work label Dec 12, 2017
tag_pt7,PT7,taxes
tag_st11,ST11,taxes
tag_pt11,PT11,taxes
tag_uk_01,Net VAT to be paid/reclaimed,taxes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should not define tags for the report lines aggregating other lines (and thus: not using any domain where to search for the tag). These tags will remain used, and hence are useless.

PT2,PT2,l10n_uk,purchase,Exempt purchases,percent,0,2201,2201,,"tag_uk_04,tag_uk_08",tax_group_0
PT8M,PT8M,l10n_uk,none,Standard rated purchases from EC,percent,17.5,2201,2201,,tag_uk_03,tax_group_0
PT8R,PT8R,l10n_uk,none,Reverse EC Purchase VAT,percent,-17.5,2201,2201,,tag_uk_05,tax_group_0
PT8,PT8,l10n_uk,purchase,Standard rated purchases from EC,group,,2201,2201,"PT8M,PT8R","tag_uk_09,tag_uk_03",tax_group_0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't only be tag_uk_09 ?

tag_st11,ST11,taxes
tag_pt11,PT11,taxes
tag_uk_01,Net VAT to be paid/reclaimed,taxes
tag_uk_02,VAT on Sales and other outputs,taxes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should give better names to all your tags, as it was done in l10n_ch (here: https://github.com/odoo/odoo/blob/11.0/addons/l10n_ch/data/account_vat2011_data.xml ). Their ids should match the ones of the record lines they correspond to.

For example, for tag_uk_02, you should name it vat_tag_0101, as it relates to line financial_report_line_uk_0101. Please do the same for all other tags.

@dat-odoo dat-odoo force-pushed the master-l10n_uk-one-tag-per-grid-rmu branch 2 times, most recently from d2f5a98 to 7e3ee72 Compare March 15, 2018 06:40
@hmo-odoo hmo-odoo added Accounting Localization about adapting the content to a specify country (usually chart of accounts) labels Mar 20, 2018
@rgo-odoo rgo-odoo force-pushed the master-l10n_uk-one-tag-per-grid-rmu branch from 7e3ee72 to 718bf86 Compare April 4, 2018 10:28
Created one tag per tax grid used in enterprise report

Was task# 22697
Was PR odoo#21493
Related enterprise PR odoo/enterprise#1676
@rgo-odoo rgo-odoo force-pushed the master-l10n_uk-one-tag-per-grid-rmu branch from 718bf86 to 1fdd8b7 Compare April 4, 2018 11:01
@jco-odoo
Copy link
Contributor

@oco-odoo As the task was cancelled, can you confirm this to be cancelled too?

@oco-odoo
Copy link
Contributor

oco-odoo commented Jan 7, 2019

@jco-odoo I suppose it must be canceled too; it depenrds on the content on the new task ;)

@jco-odoo
Copy link
Contributor

jco-odoo commented Jan 7, 2019

@oco-odoo The new task was not adapted to this. And it would simplify the config. So, we will need to adapt it.

@rdeodoo
Copy link
Contributor

rdeodoo commented Jul 12, 2019

@rdeodoo rdeodoo closed this Jul 12, 2019
@xmo-odoo xmo-odoo deleted the master-l10n_uk-one-tag-per-grid-rmu branch November 20, 2019 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accounting Localization about adapting the content to a specify country (usually chart of accounts) RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants