[IMP] web_tour: Consume step on m2o only when a record is selected #21625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbh-odoo
force-pushed
the
master-tour-m2o-dbh
branch
from
b86a7b7
to
3364017
Compare
dbh-odoo
force-pushed
the
master-tour-m2o-dbh
branch
2 times, most recently
from
878c4a8
to
d9ce65b
Compare
msh-odoo
force-pushed
the
master-tour-m2o-dbh
branch
from
885a3b6
to
74418ae
Compare
dbh-odoo
force-pushed
the
master-tour-m2o-dbh
branch
from
74418ae
to
b893f78
Compare
|
LGTM |
dbh-odoo
force-pushed
the
master-tour-m2o-dbh
branch
from
b893f78
to
fd9d63e
Compare
dbh-odoo
force-pushed
the
master-tour-m2o-dbh
branch
from
fd9d63e
to
850555d
Compare
dbh-odoo
force-pushed
the
master-tour-m2o-dbh
branch
from
850555d
to
af2b0ae
Compare
dbh-odoo
force-pushed
the
master-tour-m2o-dbh
branch
from
af2b0ae
to
b2b2c01
Compare
qsm-odoo
force-pushed
the
master-tour-m2o-dbh
branch
from
b2b2c01
to
f65b918
Compare
qsm-odoo
force-pushed
the
master-tour-m2o-dbh
branch
from
f65b918
to
8943e74
Compare
Tour steps on m2x widgets are now consumed only when an actual record is selected (not on random click on the widget). Co-authored-by: qsm-odoo <qsm@odoo.com>
qsm-odoo
force-pushed
the
master-tour-m2o-dbh
branch
from
8943e74
to
cb097f2
Compare
pniederlag
pushed a commit
to pniederlag/odoo
that referenced
this pull request
Apr 24, 2019
Tour steps on m2x widgets are now consumed only when an actual record is selected (not on random click on the widget). closes odoo#21625 Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com> Co-authored-by: qsm-odoo <qsm@odoo.com>
|
Merged, thanks! |
|
Thanks @qsm-odoo for simplifying it, as it is too old branch so I don't even remember why we did code in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses:
Task: https://www.odoo.com/web#id=41749&view_type=form&model=project.task&action=333&active_id=131&menu_id=4720
Pad: https://pad.odoo.com/p/r.fe4a77dd6c70bff48446e681c8b72028
Current behavior before PR:
Desired behavior after PR is merged:
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr