Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

11.0 Removed HR Salary Rule Categories Hierarchy menu and action #22312

Closed
wants to merge 5 commits into from
Closed

11.0 Removed HR Salary Rule Categories Hierarchy menu and action #22312

wants to merge 5 commits into from

Conversation

sswapnesh
Copy link
Contributor

Description of the issue/feature this PR addresses: The tree views were removed from the new web client. Removed Salary Rule Categories Hierarchy menu and action.

Current behavior before PR: Salary Rule Categories Hierarchy will open new form view.

Desired behavior after PR is merged: Fixes #22304

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@sswapnesh sswapnesh changed the title 11.0 remove rule categories hierarchy action 11.0 Removed HR Salary Rule Categories Hierarchy menu and action Jan 17, 2018
@Yenthe666 Yenthe666 added the 11.0 label Jan 18, 2018
@Yenthe666
Copy link
Collaborator

@mart-e can you check please?

@mart-e
Copy link
Contributor

mart-e commented Jan 18, 2018

Hello,

Sorry but no do not delete records in a stable version 👎

@mart-e mart-e closed this Jan 18, 2018
@Yenthe666
Copy link
Collaborator

@mart-e you can rebase & merge it against the master though?

@sswapnesh
Copy link
Contributor Author

sswapnesh commented Jan 18, 2018 via email

@Yenthe666
Copy link
Collaborator

@sswapnesh custom development or removing it from your own db. @mart-e doesn't want to delete the record as it is against the stable policy. If some partner/customer would have an extend or xpath on this view it would break after this commit.

@sswapnesh
Copy link
Contributor Author

@mart-e I deleted those records because It was handled same way for issue #20108

@sswapnesh
Copy link
Contributor Author

@mart-e Same Issue in Employee --> Subordinate Hierarchy
Not sure if it relates to This Issue #20203

@anassahmed
Copy link

Issues like #22304 and #20108 makes me wonder how come you release a stable version 11.0 after introducing some aggressive change like hierarchy trees removal without revising and checking your code for any reference to it?!!

It's really astonishing too how you plan to keep a very wrong and broken behavior because you're now afraid to break a stable release! ☹️

@sswapnesh sswapnesh mentioned this pull request Jan 22, 2018
Closed
mart-e added a commit that referenced this pull request Jan 29, 2018
@mart-e
[FIX] hr: open in list view
b0ce9ce 
This action was not working as the tree view has been removed
This feature was replaced by hr_org_chart module
Just display a list of the employee and subordinates

Fixes #20203
Fixes #22312
Fixes #22536
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sswapnesh @Yenthe666 @mart-e @anassahmed