Master project ux improvement pat #22845
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pat-odoo
force-pushed
the
master-project-ux-improvement-pat
branch
3 times, most recently
from
6b57cc4
to
ef5f5e9
Compare
pat-odoo
force-pushed
the
master-project-ux-improvement-pat
branch
3 times, most recently
from
1e09a6e
to
3c20e1b
Compare
mba-odoo
force-pushed
the
master-project-ux-improvement-pat
branch
3 times, most recently
from
086e855
to
f9410cb
Compare
mba-odoo
force-pushed
the
master-project-ux-improvement-pat
branch
from
f9410cb
to
4265854
Compare
mba-odoo
force-pushed
the
master-project-ux-improvement-pat
branch
3 times, most recently
from
0f3ba1b
to
2408439
Compare
|
LGTM |
mba-odoo
force-pushed
the
master-project-ux-improvement-pat
branch
2 times, most recently
from
9c2f4a0
to
fce22a6
Compare
rdeodoo
force-pushed
the
master-project-ux-improvement-pat
branch
from
fce22a6
to
3816964
Compare
|
@JKE-be This one can be merged, it had some conflicts since it was 8500 commits behind, hopefully runbot will be green. |
rdeodoo
force-pushed
the
master-project-ux-improvement-pat
branch
from
3816964
to
977de5f
Compare
|
I'm sorry, @JKE-be. r- makes no sense in the current PR state. |
added 2 commits
April 19, 2019 15:52
Fixing missed 'pivot_row_groupby' assigned to groupedBy in pivot_model.js in Load function (Already done in reload function), which was missed in commit 42f22a2. Added qunit test case for testing correct value. Apply pivot_row_groupby on user in project task-54027
Display field in two groups to display in four column. Plus, email_from is used to 'Allow communication with a customer without creating a partner'. Since this field is not very useful, it is best to hide it to clean the UI. Something was already done at aa33c81 task-54027
rdeodoo
force-pushed
the
master-project-ux-improvement-pat
branch
from
977de5f
to
ef451ce
Compare
|
Runbot should be green now, after rebase Qunit tests needed to be adapted to async/await |
|
@robodoo r+ |
|
@robodoo retry r+ rebase-ff |
|
Merge method set to rebase and fast-forward |
|
I'm sorry, @JKE-be. Retry makes no sense when the PR is not in error. This PR is already reviewed, reviewing it again is useless. |
|
@robodoo what are you waiting ? |
robodoo
pushed a commit
that referenced
this pull request
Apr 19, 2019
Display field in two groups to display in four column. Plus, email_from is used to 'Allow communication with a customer without creating a partner'. Since this field is not very useful, it is best to hide it to clean the UI. Something was already done at aa33c81 task-54027 closes #22845 Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task : https://www.odoo.com/web?#id=54027&view_type=form&model=project.task&action=333&active_id=131&menu_id=4720
Pad : https://pad.odoo.com/p/r.394011d9fd84ee9ca8fb5f7418bcf9c8
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr