[IMP] phantom_js: make timeout for ready condition customizable #24514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @yelizariev phantomjs has been dropped in v12 and replaced by chrome-headless., so the code changed a lot. As you can see here, the ready timeout is now 60s by default, so maybe it'll be enough for your usecases. If not, you can still re-target your PR and add a new argument here, and pass it to the call to Regards. cc @Xavier-Do |
|
Thank you @aab-odoo for the response. 60 sec sounds good. I'll remake the PR if I found a case when it's unsufficient |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses:
make timeout for ready condition customizable
Current behavior before PR:
it's always 10 sec and leads to red CI sometimes
Desired behavior after PR is merged:
Developers can increased the timeout
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr