[IMP] auth_signup: Imporve odoo connect template to with new layout. #24576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sga-odoo
force-pushed
the
master-auth-signup-mail-template-sga
branch
from
0e83bce
to
73a77c0
Compare
sga-odoo
force-pushed
the
master-auth-signup-mail-template-sga
branch
from
73a77c0
to
e80351d
Compare
sga-odoo
force-pushed
the
master-auth-signup-mail-template-sga
branch
from
e80351d
to
8abbb6d
Compare
sga-odoo
force-pushed
the
master-auth-signup-mail-template-sga
branch
from
8abbb6d
to
be12a1a
Compare
sga-odoo
force-pushed
the
master-auth-signup-mail-template-sga
branch
from
be12a1a
to
255e7bc
Compare
sga-odoo
force-pushed
the
master-auth-signup-mail-template-sga
branch
from
255e7bc
to
9da6b58
Compare
|
LGTM |
| </span> | ||
| </td> | ||
| <td valign="middle" align="right"> | ||
| <img src="/web/static/src/img/logo.png" style="padding: 0px; margin: 0px; height: auto; width: 80px;"/> |
There was a problem hiding this comment.
Shouldn't we use company-specific logo ?
| <field name="subject"><![CDATA[${object.create_uid.name} has invited you to connect to Odoo]]></field> | ||
| <field name="body_html" type="html"> | ||
| <table border="0" cellpadding="0" style="padding-top: 16px; background-color: #F1F1F1; font-family:Verdana, Arial,sans-serif; color: #454748; width: 100%; border-collapse:separate;"> | ||
| % set website_url = object.env['ir.config_parameter'].get_param('web.base.url') |
There was a problem hiding this comment.
Whut ? Why are you using website url as "odoo domain" ?
| <a href="${object.signup_url}" style="padding: 12px; color: #FFFFFF; border-color:#875A7B; text-decoration: none; display: inline-block; text-align: center; cursor: pointer; background-image: none; background-color: #875A7B; border: 1px solid #875A7B; border-radius:3px;">Accept invitation</a> | ||
| <br/> | ||
| <div style="margin-top:15px; margin-bottom:15px;"> | ||
| Your Odoo domain is: <br/> |
There was a problem hiding this comment.
What is an Odoo domain ?
sga-odoo
force-pushed
the
master-auth-signup-mail-template-sga
branch
from
9da6b58
to
883443e
Compare
tde-banana-odoo
force-pushed
the
master-auth-signup-mail-template-sga
branch
from
883443e
to
62bbf30
Compare
tde-banana-odoo
force-pushed
the
master-auth-signup-mail-template-sga
branch
from
cdbda1e
to
3fe6d8b
Compare
tde-banana-odoo
force-pushed
the
master-auth-signup-mail-template-sga
branch
from
3fe6d8b
to
a7b9f03
Compare
tde-banana-odoo
force-pushed
the
master-auth-signup-mail-template-sga
branch
from
a7b9f03
to
92d0325
Compare
tde-banana-odoo
force-pushed
the
master-auth-signup-mail-template-sga
branch
from
92d0325
to
344eefd
Compare
tde-banana-odoo
force-pushed
the
master-auth-signup-mail-template-sga
branch
from
344eefd
to
aa54457
Compare
tde-banana-odoo
added a commit
to odoo-dev/odoo
that referenced
this pull request
May 28, 2018
Even completely valid simple email like alfred+toto@example.com was not considered as valid. As email may contain a lot of characters and strange stuff let us be less strict on validation. This commit is related to task ID 1839609. Closes odoo#24576.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task: https://www.odoo.com/web?#id=1839609&view_type=form&model=project.task&action=333&active_id=131&menu_id=4720
PAD: https://pad.odoo.com/p/r.0660d07aa08b13c7da20d84d941a826d