[FIX] web: Expose datepicker configuration to view declarations #25044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lower-level widget itself supports passing options to the underlying datepicker library, but this is not exposed to higher-level view declaration.
With this patch, one can declare a field in a view such as:
```xml
<field name="datefield" options='{"daysOfWeekDisabled": [0, 6]}'/>
```
That option would land in the widget and disable those weekdays.
pedrobaeza
approved these changes
Jun 4, 2018
simahawk
approved these changes
Jun 4, 2018
|
Hello, Changes look goot to me, except that I would make them in master as this is not really a bugfix. Just to be sure I would ask for @ged-odoo review. |
|
I proposed it for v11 because it means no backwards compatibility problems. However, if you prefer for master, it would be good too 😊 |
|
Weird, I can't imagine how this change is breaking the test... 😕 |
| return new datepicker.DateWidget(this, {defaultDate: this.value}); | ||
| var datepicker_options; | ||
| try { | ||
| datepicker_options = this.attrs.options.datepicker; |
There was a problem hiding this comment.
Isn't it simpler to do datepicker_options = this.attrs.options.datepicker || {} ?
There was a problem hiding this comment.
I was worried about this.attrs.options being undefined, but I didn't know about this.nodeOptions. It's changed now.
ged-odoo
reviewed
Jun 13, 2018
yajo
force-pushed
the
11.0-web-datetimepicker_configurable
branch
from
37c3d23
to
51d3a98
Compare
|
Docs added |
tde-banana-odoo
pushed a commit
that referenced
this pull request
Jun 13, 2018
The lower-level widget itself supports passing options to the underlying
datepicker library. However this is not exposed to higher-level view
declaration. With this patch, one can declare a field in a view such as:
```xml
<field name="datefield" options='{"daysOfWeekDisabled": [0, 6]}'/>
```
That option would land in the widget and disable those weekdays.
Documentation has been updated accordingly.
Closes #25044.
|
Landed in 11 at 71334b1 . Thanks to everybody ! |
yajo
added a commit
to Tecnativa/web
that referenced
this pull request
Jun 13, 2018
This addon is no longer needed since odoo/odoo#25044 (comment), so I remove it.
This was referenced Jun 13, 2018
yajo
added a commit
to Tecnativa/web
that referenced
this pull request
Mar 7, 2019
This addon is no longer needed since odoo/odoo#25044 (comment), so I remove it.
yajo
added a commit
to Tecnativa/web
that referenced
this pull request
Mar 7, 2019
This addon is no longer needed since odoo/odoo#25044 (comment), so I remove it.
yajo
added a commit
to Tecnativa/web
that referenced
this pull request
Mar 7, 2019
This addon is no longer needed since odoo/odoo#25044 (comment) and odoo/odoo#27541, so I remove it.
eilst
pushed a commit
to savoirfairelinux/web
that referenced
this pull request
Apr 4, 2019
This addon is no longer needed since odoo/odoo#25044 (comment) and odoo/odoo#27541, so I remove it.
40 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lower-level widget itself supports passing options to the underlying datepicker library, but this is not exposed to higher-level view declaration.
With this patch, one can declare a field in a view such as:
That option would land in the widget and disable those weekdays.
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
@Tecnativa @ged-odoo