Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] web: Make datetimepicker configurable in datetime fields #27541

Closed
wants to merge 1 commit into from

Conversation

ged-odoo
Copy link
Contributor

@ged-odoo ged-odoo commented Oct 8, 2018

The datetimepicker option was introduced to be able to customize the
datetime picker widget in date/datetime fields. However, due to the way
the _makeDatePicker function was coded, it did not work in datetime
fields.

Thank to @yajo for the initial fix

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@ged-odoo ged-odoo requested a review from aab-odoo October 8, 2018 13:54
@robodoo robodoo added CI 🤖 Robodoo has seen passing statuses seen 🙂 labels Oct 8, 2018
@C3POdoo C3POdoo added the RD research & development, internal work label Oct 8, 2018
@robodoo robodoo removed the CI 🤖 Robodoo has seen passing statuses label Oct 9, 2018
View: FormView,
model: 'partner',
data: this.data,
arch:'<form string="Partners"><field name="datetime" options=\'{"datepicker": {"daysOfWeekDisabled": [0, 6]}}\'/></form>',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line too long

@ged-odoo
Copy link
Contributor Author

ged-odoo commented Oct 9, 2018

robodoo delegate=VincentSchippefilt

Copy link
Contributor

@yajo yajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Could you please remove @Yajo from the commit message? It spams me every time somebody clones that commit in another repo 😅

Just name me as Jairo Llopis, or Yajo without the @ please 🙏 , or link to the PR instead of me personally.

@ged-odoo
Copy link
Contributor Author

ged-odoo commented Oct 9, 2018

@yajo of course...

@ged-odoo ged-odoo force-pushed the 11.0-fixes-ged branch 2 times, most recently from e430f65 to 975a622 Compare October 9, 2018 12:34
The datetimepicker option was introduced to be able to customize the
datetime picker widget in date/datetime fields. However, due to the way
the _makeDatePicker function was coded, it did not work in datetime
fields.

Thank to Yajo for the initial fix
@ged-odoo
Copy link
Contributor Author

ged-odoo commented Oct 9, 2018

robodoo r+

@robodoo robodoo added r+ 👌 CI 🤖 Robodoo has seen passing statuses labels Oct 9, 2018
robodoo pushed a commit that referenced this pull request Oct 9, 2018
The datetimepicker option was introduced to be able to customize the
datetime picker widget in date/datetime fields. However, due to the way
the _makeDatePicker function was coded, it did not work in datetime
fields.

Thank to Yajo for the initial fix

closes #27541
@robodoo
Copy link
Contributor

robodoo commented Oct 9, 2018

Merged in 078b31d

@robodoo robodoo closed this Oct 9, 2018
yajo added a commit to Tecnativa/web that referenced this pull request Mar 7, 2019
eilst pushed a commit to savoirfairelinux/web that referenced this pull request Apr 4, 2019
@fw-bot fw-bot deleted the 11.0-fixes-ged branch October 20, 2019 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI 🤖 Robodoo has seen passing statuses RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants