[ADD] hr fleet : claim report and cars history for one employee #28077

jbm-odoo · 2018-10-23T15:15:02Z

Add a field employee_cars_count (computed) to count the amount of cars the employee drove on employee page. This button open the kanban view with all car drove by this employee.

On the fleet.vehicle.assignation.logs a button (like in expense) to upload documents about the car for a particular employee. On the employee form view, add an action button (with groups fleet_manager) to print all the documents merged in one file. On each document, there is a header to show the vehicle and the dove period.

id=1892039

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

fmdl · 2018-10-23T16:34:34Z

addons/hr_fleet/models/employee.py

+    def action_open_employee_cars(self):
+        self.ensure_one()
+        Fleet = self.env['fleet.vehicle.assignation.log']
+        car_line = Fleet.search([('driver_id','=',self.user_id.partner_id.id)]).mapped('vehicle_id').mapped('id')


you can replace by
car_line = Fleet.search([('driver_id','=',self.user_id.partner_id.id)]).mapped('vehicle_id') (remove mapped('id'))

and put "domain": [("id", "in", car_line.ids)], (add .ids)

fmdl · 2018-10-23T16:35:46Z

addons/hr_fleet/models/employee.py

+    def _compute_employee_cars_count(self):
+        Fleet = self.env['fleet.vehicle.assignation.log'].sudo()
+        for employee in self:
+            employee.employee_cars_count = Fleet.search_count([


use read_group instead search_count (only sql request for all employee)

tivisse

Some comments, mostly linting/guidelines issues. Some chunks of code could be improved too.

Globally it's a good work ! Thanks.

tivisse · 2018-10-25T09:40:21Z

addons/hr_fleet/controllers/main.py

+import base64
+import io
+
+from odoo import http, _


_ is imported but unused. Could be removed.

Could be from odoo.http import request, route, Controller. More compact.

tivisse · 2018-10-25T09:41:05Z

addons/hr_fleet/controllers/main.py

+    @http.route(["/hrfleet/claimreport/<int:employee_id>"], type='http', auth='user')
+    def get_claim_report_user(self, employee_id, **post):
+
+        user_rec = http.request.env['res.users'].sudo().search([('id', '=', http.request.session.uid)])


You could use browse instead of searching id = uid

Is the sudo really needed ?

tivisse · 2018-10-25T09:42:06Z

addons/hr_fleet/controllers/main.py

+        if not user_rec.has_group('fleet.fleet_group_manager'):
+            return http.request.not_found()
+
+        Fleet = http.request.env['fleet.vehicle.assignation.log']


Your models are used only once or twice in your method. No need to store them into variables.

tivisse · 2018-10-25T09:43:05Z

addons/hr_fleet/controllers/main.py

+        Attachment = http.request.env['ir.attachment']
+        Employee = http.request.env['hr.employee']
+
+        employee = Employee.search([('id','=',employee_id)],limit=1)


Missing space in [('id', '=', employee_id)], limit=1

You could use a linter to avoid those kind of issues. If you're using sublime-text, pylinter is a good one.

tivisse · 2018-10-25T09:44:05Z

addons/hr_fleet/controllers/main.py

+
+        partner_id = employee.user_id.partner_id.id
+        if not partner_id:
+            return http.request.not_found()


Could be factored into:

employee = Employee.search([('id', '=', employee_id)], limit=1) partner_id = employee.user_id.partner_id if not employee or not partner: return http.request.not_found()

tivisse · 2018-10-25T10:06:59Z

addons/hr_fleet/models/employee.py

+
+    def _compute_employee_cars_count(self):
+        Fleet = self.env['fleet.vehicle.assignation.log'].sudo()
+        driver_id = self.mapped('user_id').mapped('partner_id').ids


This is the same as self.mapped('user_id.partner_id').ids

And driver_id could be a list of ids, so you could rename it into driver_ids

tivisse · 2018-10-25T10:08:29Z

addons/hr_fleet/models/employee.py

+        fleet_data = Fleet.read_group(domain=[('driver_id', 'in', driver_id)], fields=['driver_id'], groupby=['driver_id'])
+        mapped_data = dict([(m['driver_id'][0], m['driver_id_count']) for m in fleet_data])
+        for employee in self:
+            employee.employee_cars_count = mapped_data.get(employee.user_id.partner_id.id)


It's great you used read_group instead of search_count. This is a good practice!

tivisse · 2018-10-25T10:08:42Z

addons/hr_fleet/models/employee.py

+            'name': 'Claim Report',
+            'type': 'ir.actions.act_url',
+            'url': '/hrfleet/claimreport/%(employee_id)s' % {'employee_id': self.id},
+        }


Linting issue (missing end of file line)

tivisse · 2018-10-25T10:10:01Z

addons/hr_fleet/controllers/main.py

+
+
+class HrFleet(http.Controller):
+    @http.route(["/hrfleet/claimreport/<int:employee_id>"], type='http', auth='user')


The route could be renamed into /fleet/print_claim_report/<int:employee_id>

tivisse · 2018-10-25T10:10:59Z

addons/hr_fleet/models/vehicle_assignation_log.py

+from odoo import api, fields, models
+
+
+class FleetVehicleAssignationLog(models.Model):


I know that the model name is not sexy, but according to the guidelines, the file should be named fleet_vehicle_assignation_log

Purpose ======= When an employee leaves the company, the fleet manager must ask to the insurance company a claim report for this employee. But in oddo, there is no easy way to have an history of the drivers. Specification ============= 1/ On the employee form, add a stat button: "x cars". The button shouldn't be displayed if the count = 0. Make a bridge (auto_install: True in the manifest) depending on hr (hr.employee) and fleet (fleet.vehicle.assignation.log) - Add a field employee_cars_count (computed) to count the amount of cars the employee drove. - Add an method action_open_employee_cars, that return an action (ir.actions.act_window) that open on the fleet.vehicle kanban filtered on cars the employee had driven. 2/ In this bridge module, add on the fleet.vehicle.assignation.logs a button (like in expense) to upload documents about the car for a particular employee (PV, rapport d'assurance, blabla). On the employee form view, add an action button (with groups fleet_manager) to print all the related documents (all the attachements on the fleet.vehicle.assignation.logs for the employee).

tivisse

Some small comments.

tivisse · 2018-11-06T12:47:06Z

addons/hr_fleet/controllers/main.py

+    @http.route(["/fleet/print_claim_report/<int:employee_id>"], type='http', auth='user')
+    def get_claim_report_user(self, employee_id, **post):
+
+        user_rec = http.request.env['res.users'].browse(http.request.session.uid)


You can get user from request.env.user. No need to browse it.

tivisse · 2018-11-06T12:50:05Z

addons/hr_fleet/controllers/main.py

+import base64
+import io
+
+from odoo import http, _


Could be from odoo.http import request, route, Controller. More compact.

tivisse · 2018-11-06T13:12:37Z

@robodoo r+

fmdl · 2018-11-06T13:33:00Z

addons/hr_fleet/views/employee_views.xml

+                <header>
+                    <button name="action_get_claim_report" string="Claim Report"
+                    type="object" groups="fleet.fleet_group_manager"
+                    attrs="{'invisible': [('employee_cars_count','=', 0)]}"


are you sur it work ?, because employee_cars_count is not prevent in the view
<field name='employee_cars_count' invisible="1"/>

@fmdl If you look, the field is present inside the second button ;)

Purpose ======= When an employee leaves the company, the fleet manager must ask to the insurance company a claim report for this employee. But in oddo, there is no easy way to have an history of the drivers. Specification ============= 1/ On the employee form, add a stat button: "x cars". The button shouldn't be displayed if the count = 0. Make a bridge (auto_install: True in the manifest) depending on hr (hr.employee) and fleet (fleet.vehicle.assignation.log) - Add a field employee_cars_count (computed) to count the amount of cars the employee drove. - Add an method action_open_employee_cars, that return an action (ir.actions.act_window) that open on the fleet.vehicle kanban filtered on cars the employee had driven. 2/ In this bridge module, add on the fleet.vehicle.assignation.logs a button (like in expense) to upload documents about the car for a particular employee (PV, rapport d'assurance, blabla). On the employee form view, add an action button (with groups fleet_manager) to print all the related documents (all the attachements on the fleet.vehicle.assignation.logs for the employee). closes #28077

robodoo · 2018-11-06T14:57:19Z

Merged, thanks!

robodoo added the seen 🙂 label Oct 23, 2018

fmdl reviewed Oct 23, 2018

View reviewed changes

C3POdoo added the RD research & development, internal work label Oct 24, 2018

robodoo added the CI 🤖 Robodoo has seen passing statuses label Oct 24, 2018

RomainLibert force-pushed the master-history-cars-drivers-jbm branch from 3290589 to 499e7d8 Compare October 24, 2018 10:48

robodoo removed the CI 🤖 Robodoo has seen passing statuses label Oct 24, 2018

jbm-odoo force-pushed the master-history-cars-drivers-jbm branch from 3290589 to 765944e Compare October 24, 2018 10:59

robodoo added the CI 🤖 Robodoo has seen passing statuses label Oct 24, 2018

tivisse reviewed Oct 25, 2018

View reviewed changes

jbm-odoo force-pushed the master-history-cars-drivers-jbm branch from 765944e to 57ed957 Compare October 25, 2018 13:18

robodoo added CI 🤖 Robodoo has seen passing statuses and removed CI 🤖 Robodoo has seen passing statuses labels Oct 25, 2018

tivisse force-pushed the master-history-cars-drivers-jbm branch from 57ed957 to 167dc68 Compare November 6, 2018 13:04

robodoo removed the CI 🤖 Robodoo has seen passing statuses label Nov 6, 2018

tivisse reviewed Nov 6, 2018

View reviewed changes

robodoo added the r+ 👌 label Nov 6, 2018

fmdl reviewed Nov 6, 2018

View reviewed changes

robodoo added the CI 🤖 Robodoo has seen passing statuses label Nov 6, 2018

robodoo added merging 👷 and removed merging 👷 labels Nov 6, 2018

robodoo closed this Nov 6, 2018

tivisse deleted the master-history-cars-drivers-jbm branch November 6, 2018 15:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ADD] hr fleet : claim report and cars history for one employee #28077

[ADD] hr fleet : claim report and cars history for one employee #28077

jbm-odoo commented Oct 23, 2018

fmdl Oct 23, 2018

fmdl Oct 23, 2018

tivisse left a comment

tivisse Oct 25, 2018

tivisse Nov 6, 2018

tivisse Oct 25, 2018

tivisse Oct 25, 2018

tivisse Oct 25, 2018

tivisse Oct 25, 2018

tivisse Oct 25, 2018

tivisse Oct 25, 2018

tivisse Oct 25, 2018

tivisse Oct 25, 2018

tivisse Oct 25, 2018

tivisse Oct 25, 2018

tivisse Oct 25, 2018

tivisse left a comment

tivisse Nov 6, 2018

tivisse Nov 6, 2018

tivisse commented Nov 6, 2018

fmdl Nov 6, 2018

tivisse Nov 6, 2018

robodoo commented Nov 6, 2018



		class HrFleet(http.Controller):
		@http.route(["/hrfleet/claimreport/<int:employee_id>"], type='http', auth='user')

		from odoo import api, fields, models


		class FleetVehicleAssignationLog(models.Model):

[ADD] hr fleet : claim report and cars history for one employee #28077

[ADD] hr fleet : claim report and cars history for one employee #28077

Conversation

jbm-odoo commented Oct 23, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tivisse left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tivisse left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tivisse commented Nov 6, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

robodoo commented Nov 6, 2018