Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLEANUP] DOC #28761

Closed
wants to merge 1 commit into from
Closed

[CLEANUP] DOC #28761

wants to merge 1 commit into from

Conversation

blaggacao
Copy link
Contributor

Those params are documented, but don't exists as documented.

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Those params are documented, but don't exists as documented.
@blaggacao
Copy link
Contributor Author

It would be also a good idea to document the difference between fields and fieldsInfo and, specifically where they come from, each.

@blaggacao
Copy link
Contributor Author

I guess, this was replaced by a more dynamic _getFieldNames so document that better, instead.

@blaggacao
Copy link
Contributor Author

     * @param {Object} params.fieldsInfo contains the fieldInfo of each view,
     *   for each field
     * @param {Object} params.fields contains the description of each field

I think it doesn't document well the behavior or at least it's not verbose enough.
Especially misleading: "description"

@blaggacao
Copy link
Contributor Author

Another overlook:
If not given, fetch all the fields in record.fieldNames
should be:
If not given, fetch all the fields returned by record.getFieldNames()

@blaggacao
Copy link
Contributor Author

Not touching code and runbot fails. lol 😯

@KangOl
Copy link
Contributor

KangOl commented Nov 16, 2018

You were based on red revision. Can you rebase?

@mart-e mart-e added the Framework General frontend/backend framework issues label Dec 20, 2018
@mart-e mart-e requested a review from ged-odoo December 20, 2018 15:09
@pedrobaeza
Copy link
Collaborator

Coming to this from codetriage.com. Is this still relevant?

@blaggacao
Copy link
Contributor Author

I'm not maintining this PR actively.

@C3POdoo
Copy link
Contributor

C3POdoo commented Apr 22, 2022

Dear @blaggacao,

Thank you for your contribution but the version 12.0 is no longer supported.
We only support the last 3 stable versions so no longer accepts patches into this branch.

We apology if we could not look at your request in time.
If the contribution still makes sense for the upper version, please let us know and do not hesitate to recreate one for the recent versions. We will try to check it as soon as possible.

This is an automated message.

@C3POdoo C3POdoo closed this Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Framework General frontend/backend framework issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants