[FIX] board: fix the domain of consecutive 'add to dashboard' operations #28843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a search containing a domain to dashboard. Remove that domain. Do a new search with a different domain. Add that search to dashboard; the domain sent would be the concatenation of the two domains. We make it so that only the last domain is sent, with a test. opw 1907650
kebeclibre
reviewed
Nov 20, 2018
kebeclibre
approved these changes
Nov 23, 2018
|
robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Nov 23, 2018
Add a search containing a domain to dashboard. Remove that domain. Do a new search with a different domain. Add that search to dashboard; the domain sent would be the concatenation of the two domains. We make it so that only the last domain is sent, with a test. opw 1907650 closes #28843
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a search containing a domain to dashboard. Remove that domain.
Do a new search with a different domain.
Add that search to dashboard;
the domain sent would be the concatenation of the two domains.
We make it so that only the last domain is sent, with a test.
opw 1907650
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr