[MERGE][IMP] survey : add datetime format and various improvements #29054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbeguin
force-pushed
the
master-survey-improvements-dbe
branch
from
9b538b6
to
8a73c9d
Compare
dbeguin
changed the title
dbeguin
force-pushed
the
master-survey-improvements-dbe
branch
from
8a73c9d
to
5fb9b61
Compare
robodoo
added
CI 🤖
dbeguin
force-pushed
the
master-survey-improvements-dbe
branch
from
5fb9b61
to
ccd2db7
Compare
robodoo
added
CI 🤖
dbeguin
force-pushed
the
master-survey-improvements-dbe
branch
from
ccd2db7
to
7f85f38
Compare
robodoo
added
CI 🤖
dbeguin
force-pushed
the
master-survey-improvements-dbe
branch
from
7f85f38
to
c6f92b6
Compare
robodoo
added
CI 🤖
dbeguin
force-pushed
the
master-survey-improvements-dbe
branch
from
c6f92b6
to
5e9723b
Compare
robodoo
added
CI 🤖
dbeguin
force-pushed
the
master-survey-improvements-dbe
branch
from
6203593
to
ae66b87
Compare
tde-banana-odoo
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Jan 17, 2019
During cleaning from ee2631c, as the kwargs were removed from arguments for some routes, debug mode was not accessible anymore as ?debug=x is, de facto, a post argument. This commit restores debug mode by restoring kwargs in those routes. Fix commit from task ID 1911586 and PR odoo#28986 Integrated in task ID 1911291 and PR odoo#29054
robodoo
pushed a commit
that referenced
this pull request
Jan 17, 2019
During cleaning from ee2631c, as the kwargs were removed from arguments for some routes, debug mode was not accessible anymore as ?debug=x is, de facto, a post argument. This commit restores debug mode by restoring kwargs in those routes. Fix commit from task ID 1911586 and PR #28986 Integrated in task ID 1911291 and PR #29054
robodoo
pushed a commit
that referenced
this pull request
Jan 17, 2019
During cleaning from ee2631c, as the kwargs were removed from arguments for some routes, debug mode was not accessible anymore as ?debug=x is, de facto, a post argument. This commit restores debug mode by restoring kwargs in those routes. Fix commit from task ID 1911586 and PR #28986 Integrated in task ID 1911291 and PR #29054
dbeguin
force-pushed
the
master-survey-improvements-dbe
branch
from
441642d
to
7a315ec
Compare
robodoo
added
CI 🤖
- Change the default value of the Validation Error message on
the Date : "The answer you entered is not valid."
- If long page, click on next and one error, the page should go up
to allow the visitor to see where the error is.
Task ID : 1911291
Closes PR odoo#29054
dbeguin
force-pushed
the
master-survey-improvements-dbe
branch
from
7a315ec
to
720f366
Compare
to be able to choose between asking for a date or a date with time, a datetime question type is now added. Task ID : 1911291 Closes PR odoo#29054
dbeguin
force-pushed
the
master-survey-improvements-dbe
branch
from
720f366
to
3504e77
Compare
|
@robodoo r+ |
|
Because this PR has multiple commits, I need to know how to merge it:
|
|
@robodoo rebase-merge with some fries and a soda. |
robodoo
pushed a commit
that referenced
this pull request
Jan 25, 2019
- Change the default value of the Validation Error message on
the Date : "The answer you entered is not valid."
- If long page, click on next and one error, the page should go up
to allow the visitor to see where the error is.
Task ID : 1911291
Closes PR #29054
robodoo
pushed a commit
that referenced
this pull request
Jan 25, 2019
to be able to choose between asking for a date or a date with time, a datetime question type is now added. Task ID : 1911291 Closes PR #29054
robodoo
added a commit
that referenced
this pull request
Jan 25, 2019
Purpose of this merge is to add support of both date and datetime questions in survey. Validation and check is added accordingly to current survey question type support. In this merge we also add some various improvements * Change the default value of the Validation Error message on the Date : "The answer you entered is not valid." * If long page, click on next and one error, the page should go up to allow the visitor to see where the error is. This merge is related to task ID 1911291 and closes PR #29054.
|
Merge method set to rebase and merge, using the PR as merge commit message |
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this merge is to add support of both date and datetime questions
in survey. Validation and check is added accordingly to current survey
question type support.
In this merge we also add some various improvements
the Date : "The answer you entered is not valid."
to allow the visitor to see where the error is.
This merge is related to task ID 1911291 and closes PR #29054.