Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] barcodes, web: float scannable #31366

Closed
wants to merge 1 commit into from

Conversation

nim-odoo
Copy link
Contributor

  • Switch to French language
  • Go to Inventory > Inventory Adjustment
  • Launch an adjustment

The field 'Real Quantity' doesn't follow the float formatting.

This is because the widget is set as field_float_scannable, which is
not recognized by the formatting function.

Since the widget descriptor has priority over the type descriptor, we
must explicitly take this widget into account, on top of adding the
format_value method.

opw-1940884

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

- Switch to French language
- Go to Inventory > Inventory Adjustment
- Launch an adjustment

The field 'Real Quantity' doesn't follow the float formatting.

This is because the widget is set as `field_float_scannable`, which is
not recognized by the formatting function.

Since the widget descriptor has priority over the type descriptor, we
must explicitly take this widget into account, on top of adding the
`format_value` method.

opw-1940884
@nim-odoo nim-odoo self-assigned this Feb 22, 2019
@nim-odoo nim-odoo added the OE the report is linked to a support ticket (opw-...) label Feb 22, 2019
@robodoo robodoo added the CI 🤖 Robodoo has seen passing statuses label Feb 22, 2019
@nim-odoo
Copy link
Contributor Author

robodoo r+

robodoo pushed a commit that referenced this pull request Feb 26, 2019
- Switch to French language
- Go to Inventory > Inventory Adjustment
- Launch an adjustment

The field 'Real Quantity' doesn't follow the float formatting.

This is because the widget is set as `field_float_scannable`, which is
not recognized by the formatting function.

Since the widget descriptor has priority over the type descriptor, we
must explicitly take this widget into account, on top of adding the
`format_value` method.

opw-1940884

closes #31366
@robodoo
Copy link
Contributor

robodoo commented Feb 26, 2019

Merged, thanks!

@robodoo robodoo closed this Feb 26, 2019
@nim-odoo nim-odoo deleted the 10.0-opw-1940884-scannable-nim branch February 26, 2019 08:48
remihb pushed a commit to osiell/OCB that referenced this pull request Mar 28, 2019
- Switch to French language
- Go to Inventory > Inventory Adjustment
- Launch an adjustment

The field 'Real Quantity' doesn't follow the float formatting.

This is because the widget is set as `field_float_scannable`, which is
not recognized by the formatting function.

Since the widget descriptor has priority over the type descriptor, we
must explicitly take this widget into account, on top of adding the
`format_value` method.

opw-1940884

closes odoo#31366
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI 🤖 Robodoo has seen passing statuses OE the report is linked to a support ticket (opw-...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants