Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] barcodes, web: float scannable #31366

Closed
wants to merge 1 commit into
base: 10.0
from

Conversation

Projects
None yet
2 participants
@nim-odoo
Copy link
Contributor

nim-odoo commented Feb 22, 2019

  • Switch to French language
  • Go to Inventory > Inventory Adjustment
  • Launch an adjustment

The field 'Real Quantity' doesn't follow the float formatting.

This is because the widget is set as field_float_scannable, which is
not recognized by the formatting function.

Since the widget descriptor has priority over the type descriptor, we
must explicitly take this widget into account, on top of adding the
format_value method.

opw-1940884

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

[FIX] barcodes, web: float scannable
- Switch to French language
- Go to Inventory > Inventory Adjustment
- Launch an adjustment

The field 'Real Quantity' doesn't follow the float formatting.

This is because the widget is set as `field_float_scannable`, which is
not recognized by the formatting function.

Since the widget descriptor has priority over the type descriptor, we
must explicitly take this widget into account, on top of adding the
`format_value` method.

opw-1940884

@nim-odoo nim-odoo self-assigned this Feb 22, 2019

@robodoo robodoo added the seen 🙂 label Feb 22, 2019

@nim-odoo nim-odoo added the OE label Feb 22, 2019

@robodoo robodoo added the CI 🤖 label Feb 22, 2019

@nim-odoo

This comment has been minimized.

Copy link
Contributor Author

nim-odoo commented Feb 26, 2019

robodoo r+

@robodoo robodoo added the r+ 👌 label Feb 26, 2019

robodoo pushed a commit that referenced this pull request Feb 26, 2019

[FIX] barcodes, web: float scannable
- Switch to French language
- Go to Inventory > Inventory Adjustment
- Launch an adjustment

The field 'Real Quantity' doesn't follow the float formatting.

This is because the widget is set as `field_float_scannable`, which is
not recognized by the formatting function.

Since the widget descriptor has priority over the type descriptor, we
must explicitly take this widget into account, on top of adding the
`format_value` method.

opw-1940884

closes #31366
@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Feb 26, 2019

Merged, thanks!

@robodoo robodoo closed this Feb 26, 2019

@nim-odoo nim-odoo deleted the odoo-dev:10.0-opw-1940884-scannable-nim branch Feb 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.