Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] hr_payroll: Create belgian demo data in a specific test module #31375

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@tivisse
Copy link
Contributor

tivisse commented Feb 22, 2019

Revert the commit in which we added l10n_be as dependency of l10n_be_hr_payroll

Move the demo data into a specific test module, to avoid crashes when installing
the module, that create payslips on the Belgian company, the auto install l10n_us
that tries to unlink the journals and the accounts.

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo robodoo added the seen 🙂 label Feb 22, 2019

@C3POdoo C3POdoo added the RD label Feb 22, 2019

@robodoo robodoo added the CI 🤖 label Feb 22, 2019

@tivisse tivisse force-pushed the odoo-dev:master-belgian-payroll-yti branch Feb 25, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Feb 25, 2019

@tivisse tivisse force-pushed the odoo-dev:master-belgian-payroll-yti branch Feb 26, 2019

@robodoo robodoo added CI 🤖 and removed CI 🤖 labels Feb 26, 2019

[IMP] hr_payroll: Create belgian demo data in a specific test module
Revert the commit in which we added l10n_be as dependency of l10n_be_hr_payroll

Move the demo data into a specific test module, to avoid crashes when installing
the module, that create payslips on the Belgian company, the auto install l10n_us
that tries to unlink the journals and the accounts.

@tivisse tivisse force-pushed the odoo-dev:master-belgian-payroll-yti branch to e30fef2 Mar 5, 2019

@tivisse

This comment has been minimized.

Copy link
Contributor Author

tivisse commented Mar 5, 2019

@robodoo robodoo added r+ 👌 CI 🤖 and removed CI 🤖 labels Mar 5, 2019

@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Mar 5, 2019

Linked pull request(s) odoo/enterprise#3713 not ready. Linked PRs are not staged until all of them are ready.

robodoo pushed a commit that referenced this pull request Mar 5, 2019

[IMP] hr_payroll: Create belgian demo data in a specific test module
Revert the commit in which we added l10n_be as dependency of l10n_be_hr_payroll

Move the demo data into a specific test module, to avoid crashes when installing
the module, that create payslips on the Belgian company, the auto install l10n_us
that tries to unlink the journals and the accounts.

closes #31375

Signed-off-by: "Yannick Tivisse (yti)" <yti@odoo.com>
@robodoo

This comment has been minimized.

Copy link
Contributor

robodoo commented Mar 5, 2019

Merged, thanks!

@robodoo robodoo closed this Mar 5, 2019

@tivisse tivisse deleted the odoo-dev:master-belgian-payroll-yti branch Mar 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.